Source/core/rendering/shapes/BoxShapeTest.cpp - Issue 226373002: [CSS Shapes] shape-margin in percentage units always computes to 0px

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/shapes/BoxShapeTest.cpp

Issue 226373002: [CSS Shapes] shape-margin in percentage units always computes to 0px (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix test Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-shape-margin-percent.html ('K') | « Source/core/css/parser/CSSPropertyParser.cpp ('k') | Source/core/rendering/shapes/Shape.h » ('j') | Source/core/rendering/shapes/ShapeOutsideInfo.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/shapes/BoxShapeTest.cpp

diff --git a/Source/core/rendering/shapes/BoxShapeTest.cpp b/Source/core/rendering/shapes/BoxShapeTest.cpp

index 977b0f90d2a56a8048e5f4d14475931f253675a9..74538f391fd468581e98c107371829f28bc585a7 100644

--- a/Source/core/rendering/shapes/BoxShapeTest.cpp

+++ b/Source/core/rendering/shapes/BoxShapeTest.cpp

@@ -43,7 +43,7 @@ protected:

PassOwnPtr<Shape> createBoxShape(const RoundedRect& bounds, float shapeMargin)

{

- return Shape::createLayoutBoxShape(bounds, TopToBottomWritingMode, Length(shapeMargin, Fixed));

+ return Shape::createLayoutBoxShape(bounds, TopToBottomWritingMode, shapeMargin);

}

};