Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: components/password_manager/core/browser/password_form_manager.h

Issue 2263683002: credentials_to_update should own its PasswordForms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@621355_dont_set_preferred
Patch Set: No empty->null Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_form_manager.h
diff --git a/components/password_manager/core/browser/password_form_manager.h b/components/password_manager/core/browser/password_form_manager.h
index a96274b33278986afeaf18ecdabf2884178c4d6d..7ad85312ca3cb5fde9bc3fb69a46a911ea85d1ba 100644
--- a/components/password_manager/core/browser/password_form_manager.h
+++ b/components/password_manager/core/browser/password_form_manager.h
@@ -463,11 +463,11 @@ class PasswordFormManager : public PasswordStoreConsumer {
// update the password store. It also goes through |not_best_matches|,
// updates the password of those which share the old password and username
// with |pending_credentials_| to the new password of |pending_credentials_|,
- // and adds pointers to all such modified credentials to
+ // and adds copies of all such modified credentials to
// |credentials_to_update|. If needed, this also returns a PasswordForm to be
// used as the old primary key during the store update.
base::Optional<autofill::PasswordForm> UpdatePendingAndGetOldKey(
- std::vector<const autofill::PasswordForm*>* credentials_to_update);
+ std::vector<autofill::PasswordForm>* credentials_to_update);
// Set of nonblacklisted PasswordForms from the DB that best match the form
// being managed by this. Use a map instead of vector, because we most

Powered by Google App Engine
This is Rietveld 408576698