components/password_manager/core/browser/form_saver_impl_unittest.cc - Issue 2263683002: credentials_to_update should own its PasswordForms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/form_saver_impl_unittest.cc

Issue 2263683002: credentials_to_update should own its PasswordForms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@621355_dont_set_preferred

Patch Set: No empty->null Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/form_saver_impl.cc ('k') | components/password_manager/core/browser/password_form_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/form_saver_impl_unittest.cc

diff --git a/components/password_manager/core/browser/form_saver_impl_unittest.cc b/components/password_manager/core/browser/form_saver_impl_unittest.cc

index 3a1d97562003e4b36d840639c9f3d3ba8fbf2038..6a143b3c4573f48c448a73ca4d52dab72464f251 100644

--- a/components/password_manager/core/browser/form_saver_impl_unittest.cc

+++ b/components/password_manager/core/browser/form_saver_impl_unittest.cc

@@ -137,8 +137,7 @@ TEST_F(FormSaverImplTest, Save_UpdateAlsoOtherCredentials) {

PasswordForm related2 = pending;

related2.origin = GURL("http://complete.example.net");

related2.signon_realm = related2.origin.spec();

- std::vector<const autofill::PasswordForm*> credentials_to_update = {

- &related1, &related2};

+ std::vector<PasswordForm> credentials_to_update = {related1, related2};

pending.password_value = ASCIIToUTF16("abcd");

PasswordForm saved[3];