components/password_manager/core/browser/form_saver_impl.h - Issue 2263683002: credentials_to_update should own its PasswordForms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/form_saver_impl.h

Issue 2263683002: credentials_to_update should own its PasswordForms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@621355_dont_set_preferred

Patch Set: No empty->null Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/form_saver.h ('k') | components/password_manager/core/browser/form_saver_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/form_saver_impl.h

diff --git a/components/password_manager/core/browser/form_saver_impl.h b/components/password_manager/core/browser/form_saver_impl.h

index 7fac37f38d60a6f90a239729609c631b5b03909d..6aa9f1ba8e1d87d28bc31e928a3236a27bce161b 100644

--- a/components/password_manager/core/browser/form_saver_impl.h

+++ b/components/password_manager/core/browser/form_saver_impl.h

@@ -28,11 +28,10 @@ class FormSaverImpl : public FormSaver {

void Save(const autofill::PasswordForm& pending,

const autofill::PasswordFormMap& best_matches,

const autofill::PasswordForm* old_primary_key) override;

- void Update(

- const autofill::PasswordForm& pending,

- const autofill::PasswordFormMap& best_matches,

- const std::vector<const autofill::PasswordForm*>* credentials_to_update,

- const autofill::PasswordForm* old_primary_key) override;

+ void Update(const autofill::PasswordForm& pending,

+ const autofill::PasswordFormMap& best_matches,

+ const std::vector<autofill::PasswordForm>* credentials_to_update,

+ const autofill::PasswordForm* old_primary_key) override;

void PresaveGeneratedPassword(

const autofill::PasswordForm& generated) override;

void RemovePresavedPassword() override;

@@ -48,7 +47,7 @@ class FormSaverImpl : public FormSaver {

const autofill::PasswordForm& pending,

bool is_new_login,

const autofill::PasswordFormMap& best_matches,

- const std::vector<const autofill::PasswordForm*>* credentials_to_update,

+ const std::vector<autofill::PasswordForm>* credentials_to_update,

const autofill::PasswordForm* old_primary_key);

// Marks all of |best_matches_| as not preferred unless the username is