components/password_manager/core/browser/form_saver.h - Issue 2263683002: credentials_to_update should own its PasswordForms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/form_saver.h

Issue 2263683002: credentials_to_update should own its PasswordForms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@621355_dont_set_preferred

Patch Set: No empty->null Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/password_manager/core/browser/form_saver.h

diff --git a/components/password_manager/core/browser/form_saver.h b/components/password_manager/core/browser/form_saver.h

index 825dddc5685ff33ce9d6c788f68fd170d14fccb2..27916b10498bfe9539cc11c46628ff36be35806c 100644

--- a/components/password_manager/core/browser/form_saver.h

+++ b/components/password_manager/core/browser/form_saver.h

@@ -26,8 +26,7 @@ class FormSaver {

// Saves the |pending| form and updates the stored preference on

// |best_matches|. If |old_primary_key| is given, uses it for saving

- // |pending|. It also updates the password store with all

- // |credentials_to_update|.

+ // |pending|.

virtual void Save(const autofill::PasswordForm& pending,

const autofill::PasswordFormMap& best_matches,

const autofill::PasswordForm* old_primary_key) = 0;

@@ -39,7 +38,7 @@ class FormSaver {

virtual void Update(

const autofill::PasswordForm& pending,

const autofill::PasswordFormMap& best_matches,

- const std::vector<const autofill::PasswordForm*>* credentials_to_update,

+ const std::vector<autofill::PasswordForm>* credentials_to_update,

const autofill::PasswordForm* old_primary_key) = 0;

// Ensures that |generated| is saved in the store. This is in ideal case

« no previous file with comments | « no previous file | components/password_manager/core/browser/form_saver_impl.h » ('j') | no next file with comments »