Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: chrome/browser/android/webapk/webapk_update_manager.cc

Issue 2263673003: Pass icon and icon murmur2 hash to WebApkInstaller when updating WebAPKs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapk/webapk_update_manager.cc
diff --git a/chrome/browser/android/webapk/webapk_update_manager.cc b/chrome/browser/android/webapk/webapk_update_manager.cc
index d6e7dbf21319901f7bde75c1be8650575d27e558..5db259398ff7447aff9e689658168022fb8a0f5c 100644
--- a/chrome/browser/android/webapk/webapk_update_manager.cc
+++ b/chrome/browser/android/webapk/webapk_update_manager.cc
@@ -51,6 +51,7 @@ static void UpdateAsync(JNIEnv* env,
const JavaParamRef<jstring>& java_short_name,
const JavaParamRef<jstring>& java_icon_url,
const JavaParamRef<jobject>& java_icon_bitmap,
+ jlong java_icon_murmur2_hash,
jint java_display_mode,
jint java_orientation,
jlong java_theme_color,
@@ -93,5 +94,6 @@ static void UpdateAsync(JNIEnv* env,
installer->UpdateAsync(
profile,
base::Bind(&WebApkUpdateManager::OnBuiltWebApk, webapk_package),
+ std::to_string(java_icon_murmur2_hash),
pkotwicz 2016/08/19 23:38:17 I think that using base::Uint64ToString() is prefe
Xi Han 2016/08/26 17:54:08 I move the conversion to Java and pass a string di
webapk_package, java_webapk_version);
}

Powered by Google App Engine
This is Rietveld 408576698