chrome/browser/android/webapk/webapk_installer_unittest.cc - Issue 2263673003: Pass icon and icon murmur2 hash to WebApkInstaller when updating WebAPKs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/webapk/webapk_installer_unittest.cc

Issue 2263673003: Pass icon and icon murmur2 hash to WebApkInstaller when updating WebAPKs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/webapk/webapk_installer.cc ('K') | « chrome/browser/android/webapk/webapk_installer.cc ('k') | chrome/browser/android/webapk/webapk_update_manager.cc » ('j') | chrome/browser/android/webapk/webapk_update_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/webapk/webapk_installer_unittest.cc

diff --git a/chrome/browser/android/webapk/webapk_installer_unittest.cc b/chrome/browser/android/webapk/webapk_installer_unittest.cc

index 2a2a58daae1ee83c54011df1f3e0768c302b58c4..9d735f276d942107eddfecf5823a19a51e98e357 100644

--- a/chrome/browser/android/webapk/webapk_installer_unittest.cc

+++ b/chrome/browser/android/webapk/webapk_installer_unittest.cc

@@ -101,12 +101,14 @@ class WebApkInstallerRunner {

void RunUpdateWebApk() {

const int webapk_version = 1;

pkotwicz 2016/08/19 23:38:17 Nit: |webapk_version| -> |kWebApkVersion|

Xi Han 2016/08/26 17:54:08 Done.

+ const long icon_murmur2_hash = 0L;

pkotwicz 2016/08/19 23:38:17 How about: "const std::string kIconMurmur2Hash = "

Xi Han 2016/08/26 17:54:08 Done.

WebApkInstaller* installer = CreateWebApkInstaller();

installer->UpdateAsyncWithURLRequestContextGetter(

url_request_context_getter_.get(),

base::Bind(&WebApkInstallerRunner::OnCompleted, base::Unretained(this)),

+ std::to_string(icon_murmur2_hash),

kDownloadedWebApkPackageName,

webapk_version);