Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 2263593003: Remove GenMailboxCHROMIUM command (Closed)

Created:
4 years, 4 months ago by piman
Modified:
4 years, 4 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@autogen_create_and_consume
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove GenMailboxCHROMIUM command It's not used (everything happens client-side) BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/c62ab55327ca4e168a0aee29afd7d0672d60d492 Cr-Commit-Position: refs/heads/master@{#413510}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -83 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format.h View 1 chunk +0 lines, -11 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_ids_autogen.h View 1 chunk +55 lines, -56 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (9 generated)
piman
4 years, 4 months ago (2016-08-20 01:02:55 UTC) #4
Zhenyao Mo
On 2016/08/20 01:02:55, piman wrote: lgtm Thanks for cleaning this up
4 years, 4 months ago (2016-08-20 01:10:15 UTC) #6
commit-bot: I haz the power
This CL has an open dependency (Issue 2257533007 Patch 1). Please resolve the dependency and ...
4 years, 4 months ago (2016-08-20 01:25:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2263593003/1
4 years, 4 months ago (2016-08-22 17:07:44 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 19:42:21 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 19:43:41 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c62ab55327ca4e168a0aee29afd7d0672d60d492
Cr-Commit-Position: refs/heads/master@{#413510}

Powered by Google App Engine
This is Rietveld 408576698