Autogenerate CreateAndConsumeTextureCHROMIUM handler

Autogenerate CreateAndConsumeTextureCHROMIUM handler

CreateAndConsumeTextureCHROMIUM is an odd function that doesn't really fit in
any of the models (it's a bit of a mix between "Create" and "PUT"). Rather than
doing a 1-off model, introduce in the generator a notion of an "internal"
function, that only generates a command, that is never directly exposed to the
client interfaces.
Introduce a CreateAndConsumeTextureINTERNAL that fits the existing "PUT" model,
and trivially implement CreateAndConsumeTextureCHROMIUM in terms of the former.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/b6e1387697acb8c6378d97aad06266793b63ded1
Cr-Commit-Position: refs/heads/master@{#413366}

[piman, 2016-08-19 21:44:44]

Description was changed from

==========
Autogenerate CreateAndConsumeTextureCHROMIUM handler

CreateAndConsumeTextureCHROMIUM is an odd function that doesn't really fit in
any of the models (it's a bit of a mix between "Create" and "PUT"). Rather than
doing a 1-off model, introduce in the generator a notion of an "internal"
function, that only generates a command, that is never directly exposed to the
client interfaces.
Introduce a CreateAndConsumeTextureINTERNAL that fits the existing "PUT" model,
and trivially implement CreateAndConsumeTextureCHROMIUM in terms of the former.

BUG=None
==========

to

==========
Autogenerate CreateAndConsumeTextureCHROMIUM handler

CreateAndConsumeTextureCHROMIUM is an odd function that doesn't really fit in
any of the models (it's a bit of a mix between "Create" and "PUT"). Rather than
doing a 1-off model, introduce in the generator a notion of an "internal"
function, that only generates a command, that is never directly exposed to the
client interfaces.
Introduce a CreateAndConsumeTextureINTERNAL that fits the existing "PUT" model,
and trivially implement CreateAndConsumeTextureCHROMIUM in terms of the former.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[piman, 2016-08-19 21:44:49]

The CQ bit was checked by piman@chromium.org to run a CQ dry run

[piman, 2016-08-19 21:45:13]

piman@chromium.org changed reviewers:
+ zmo@chromium.org

[piman, 2016-08-19 21:45:13]

WDYT?

[commit-bot: I haz the power, 2016-08-19 21:45:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 23:35:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 23:35:42]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Zhenyao Mo, 2016-08-20 01:15:45]

lgtm

This is a clever solution. I like it.

[piman, 2016-08-20 01:24:58]

The CQ bit was checked by piman@chromium.org

[commit-bot: I haz the power, 2016-08-20 01:25:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 03:22:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 03:22:25]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[piman, 2016-08-20 03:53:51]

The CQ bit was checked by piman@chromium.org

[commit-bot: I haz the power, 2016-08-20 03:54:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 05:30:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 05:30:34]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Zhenyao Mo, 2016-08-21 04:06:07]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2016-08-21 04:06:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-21 05:03:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-21 05:04:28]

Description was changed from

==========
Autogenerate CreateAndConsumeTextureCHROMIUM handler

CreateAndConsumeTextureCHROMIUM is an odd function that doesn't really fit in
any of the models (it's a bit of a mix between "Create" and "PUT"). Rather than
doing a 1-off model, introduce in the generator a notion of an "internal"
function, that only generates a command, that is never directly exposed to the
client interfaces.
Introduce a CreateAndConsumeTextureINTERNAL that fits the existing "PUT" model,
and trivially implement CreateAndConsumeTextureCHROMIUM in terms of the former.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Autogenerate CreateAndConsumeTextureCHROMIUM handler

CreateAndConsumeTextureCHROMIUM is an odd function that doesn't really fit in
any of the models (it's a bit of a mix between "Create" and "PUT"). Rather than
doing a 1-off model, introduce in the generator a notion of an "internal"
function, that only generates a command, that is never directly exposed to the
client interfaces.
Introduce a CreateAndConsumeTextureINTERNAL that fits the existing "PUT" model,
and trivially implement CreateAndConsumeTextureCHROMIUM in terms of the former.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/b6e1387697acb8c6378d97aad06266793b63ded1
Cr-Commit-Position: refs/heads/master@{#413366}
==========

[commit-bot: I haz the power, 2016-08-21 05:04:28]

Patchset 1 (id:??) landed as
https://crrev.com/b6e1387697acb8c6378d97aad06266793b63ded1
Cr-Commit-Position: refs/heads/master@{#413366}