Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

Issue 2263503003: Set WebPagePopupImpl's bounds even if they don't appear to have changed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebPagePopupImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
index 3cb532e2e255207fbe02142da6d69905fc540d7f..c8f36c89ef9e0692629cc21ecf3196408a3a8325 100644
--- a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
+++ b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
@@ -419,12 +419,11 @@ void WebPagePopupImpl::resize(const WebSize& newSizeInViewport)
WebRect windowRect = windowRectInScreen();
- if (windowRect.width != newSize.width
- && windowRect.height != newSize.height) {
- windowRect.width = newSize.width;
- windowRect.height = newSize.height;
- setWindowRect(windowRect);
- }
+ // TODO(bokan): We should only call into this if the bounds actually changed
+ // but this reveals a bug in Aura. crbug.com/633140.
+ windowRect.width = newSize.width;
+ windowRect.height = newSize.height;
+ setWindowRect(windowRect);
if (m_page) {
toLocalFrame(m_page->mainFrame())->view()->resize(newSizeInViewport);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698