Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2263453002: Use enclosing rect to find WindowTreeHost size. (Closed)

Created:
4 years, 4 months ago by jbauman
Modified:
4 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul, scottmg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use enclosing rect to find WindowTreeHost size. This was using the floored size, so with fractional device scale factors the right and bottom pixels sometimes aren't drawn. The resulting black area looks ugly with opaque windows (e.g. with a theme on the browser window). BUG=607993 Committed: https://crrev.com/e94bb783688613f83f8ba7c6a9b006e751f28aa3 Cr-Commit-Position: refs/heads/master@{#413515}

Patch Set 1 #

Patch Set 2 : add unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -3 lines) Patch
M ui/aura/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/window_tree_host.cc View 2 chunks +5 lines, -3 lines 0 comments Download
A ui/aura/window_tree_host_unittest.cc View 1 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
jbauman
4 years, 4 months ago (2016-08-20 01:20:42 UTC) #9
sky
LGTM
4 years, 4 months ago (2016-08-22 14:53:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2263453002/20001
4 years, 4 months ago (2016-08-22 17:19:15 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-22 19:47:10 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 19:48:21 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e94bb783688613f83f8ba7c6a9b006e751f28aa3
Cr-Commit-Position: refs/heads/master@{#413515}

Powered by Google App Engine
This is Rietveld 408576698