Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2263343002: Move clip mask generation into GrReducedClip (Closed)

Created:
4 years, 4 months ago by csmartdalton
Modified:
4 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@upload2_clipclears
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move clip mask generation into GrReducedClip This is a temporary solution to facilitate window rectangles and make clip mask generation more accessible for testing. The eventual goal is to simplify clips and merge GrReducedClip into GrClipStackClip. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2263343002 Committed: https://skia.googlesource.com/skia/+/bde96c6263112de755a2573f6f5f02703386f328

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Move clip mask generation into GrReducedClip #

Patch Set 4 : rebase #

Patch Set 5 : msvc #

Patch Set 6 : msvc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+380 lines, -391 lines) Patch
M include/gpu/GrContext.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M src/gpu/GrClipStackClip.h View 1 2 3 1 chunk +3 lines, -14 lines 0 comments Download
M src/gpu/GrClipStackClip.cpp View 1 2 3 4 9 chunks +28 lines, -356 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 2 4 chunks +11 lines, -11 lines 0 comments Download
M src/gpu/GrContextPriv.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrReducedClip.h View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M src/gpu/GrReducedClip.cpp View 1 2 3 4 5 2 chunks +323 lines, -0 lines 0 comments Download
M src/gpu/GrStencilAttachment.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 2 2 chunks +2 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (8 generated)
csmartdalton
4 years, 4 months ago (2016-08-22 17:38:29 UTC) #3
bsalomon
lgtm
4 years, 4 months ago (2016-08-22 17:55:53 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 2262473003 Patch 40001). Please resolve the dependency and ...
4 years, 4 months ago (2016-08-22 18:05:55 UTC) #7
csmartdalton
Still just a simple rearrangement of code that will be dying soon...
4 years, 3 months ago (2016-08-31 03:47:20 UTC) #10
bsalomon
lgtm
4 years, 3 months ago (2016-08-31 17:44:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2263343002/100001
4 years, 3 months ago (2016-08-31 19:38:13 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 19:54:49 UTC) #15
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/bde96c6263112de755a2573f6f5f02703386f328

Powered by Google App Engine
This is Rietveld 408576698