Apply gerrit ref if it is a Gerrit patch

Apply gerrit ref if it is a Gerrit patch.

Also:
* Pass through a new property 'patch_storage' to DM/Nanobench/Coverage. This will be used by the different frameworks to figure out if it is Rietveld or Gerrit issue.
* Calculate issue and patchset for Gerrit patches similar to Rietveld.

BUG=skia:5627
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2263323002

Committed: https://skia.googlesource.com/skia/+/3f1c9c0a7227d4ea45c39eb1e596538bb483f65a

[rmistry, 2016-08-22 17:18:40]

Description was changed from

==========
Apply gerrit ref if it is a Gerrit patch

BUG=skia:5627
==========

to

==========
Apply gerrit ref if it is a Gerrit patch

BUG=skia:5627
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2263323002
==========

[rmistry, 2016-08-22 17:55:42]

Patchset #1 (id:1) has been deleted

[rmistry, 2016-08-22 17:55:47]

Patchset #1 (id:20001) has been deleted

[rmistry, 2016-08-22 17:55:53]

Patchset #2 (id:60001) has been deleted

[rmistry, 2016-08-22 17:59:35]

Patchset #2 (id:80001) has been deleted

[rmistry, 2016-08-22 18:47:54]

Patchset #5 (id:160001) has been deleted

[rmistry, 2016-08-22 18:49:27]

Patchset #5 (id:180001) has been deleted

[rmistry, 2016-08-23 13:45:11]

rmistry@google.com changed reviewers:
+ borenet@google.com

[rmistry, 2016-08-23 13:45:11]

I did try out directly using bot_update.ensure_checkout but the diff was too
scary for me to reliably say everything is ok. I will have to leave using
ensure_checkout one day to you since you have way more experience with the right
commands for checkouts than me. This approach uses the same code bot_update uses
for Gerrit without having to change how all bots handle checkouts.

Also, all the corresponding changes to preserve Gerrit properties are still
required like they were for Rietveld properties because we trigger our own jobs.

[rmistry, 2016-08-23 14:00:41]

https://codereview.chromium.org/2263323002/diff/240001/infra/bots/recipes/swa...
File infra/bots/recipes/swarm_test.py (right):

https://codereview.chromium.org/2263323002/diff/240001/infra/bots/recipes/swa...
infra/bots/recipes/swarm_test.py:438: 'event.change.number',
api.vars.gerrit_issue,
Actually I do not think this is right. This needs to be issue and patchset as
well. Same for swarm_perf.

[rmistry, 2016-08-23 15:31:21]

Description was changed from

==========
Apply gerrit ref if it is a Gerrit patch

BUG=skia:5627
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2263323002
==========

to

==========
Apply gerrit ref if it is a Gerrit patch.

Also:
* Pass through a new property 'patch_storage' to DM/Nanobench/Coverage. This
will be used by the different frameworks to figure out if it is Rietveld or
Gerrit issue.
* Calculate issue and patchset for Gerrit patches similar to Rietveld.

BUG=skia:5627
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2263323002
==========

[rmistry, 2016-08-23 16:18:17]

Fixed things. This should be ready for review now.

[borenet, 2016-08-23 18:45:33]

LGTM

https://codereview.chromium.org/2263323002/diff/280001/infra/bots/recipes/swa...
File infra/bots/recipes/swarm_trigger.py (right):

https://codereview.chromium.org/2263323002/diff/280001/infra/bots/recipes/swa...
infra/bots/recipes/swarm_trigger.py:484: upload_args.append(get_issue_num(api))
I'm just realizing that it's weird we don't include the patchset in the DM or
nanobench results.  Not important to fix right now, but when we get to the point
where we want to show the test results for trybots before submitting the CL, the
patchset is going to be important.

[rmistry, 2016-08-23 19:04:37]

https://codereview.chromium.org/2263323002/diff/280001/infra/bots/recipes/swa...
File infra/bots/recipes/swarm_trigger.py (right):

https://codereview.chromium.org/2263323002/diff/280001/infra/bots/recipes/swa...
infra/bots/recipes/swarm_trigger.py:484: upload_args.append(get_issue_num(api))
On 2016/08/23 18:45:33, borenet wrote:
> I'm just realizing that it's weird we don't include the patchset in the DM or
> nanobench results.  Not important to fix right now, but when we get to the
point
> where we want to show the test results for trybots before submitting the CL,
the
> patchset is going to be important.

We do include the patchset in the DM and nanobench JSON file via properties in
swarm_test and swarm_perf. This is just the Google Storage path where the JSON
file is stored. I found out today that the path is not really used to determine
the issue and patchset but the JSON file is. Also I am not sure what happens
when new results come in from a different patchset and things are overridden
within the hour.

[rmistry, 2016-08-23 19:05:26]

On 2016/08/23 19:04:37, rmistry wrote:
>
https://codereview.chromium.org/2263323002/diff/280001/infra/bots/recipes/swa...
> File infra/bots/recipes/swarm_trigger.py (right):
> 
>
https://codereview.chromium.org/2263323002/diff/280001/infra/bots/recipes/swa...
> infra/bots/recipes/swarm_trigger.py:484:
upload_args.append(get_issue_num(api))
> On 2016/08/23 18:45:33, borenet wrote:
> > I'm just realizing that it's weird we don't include the patchset in the DM
or
> > nanobench results.  Not important to fix right now, but when we get to the
> point
> > where we want to show the test results for trybots before submitting the CL,
> the
> > patchset is going to be important.
> 
> We do include the patchset in the DM and nanobench JSON file via properties in
> swarm_test and swarm_perf. This is just the Google Storage path where the JSON
> file is stored. I found out today that the path is not really used to
determine
> the issue and patchset but the JSON file is. Also I am not sure what happens
> when new results come in from a different patchset and things are overridden
> within the hour.

Oh looks like the path also contains the builder name and build number, so
things should not be overriden.

[borenet, 2016-08-23 19:06:29]

https://codereview.chromium.org/2263323002/diff/280001/infra/bots/recipes/swa...
File infra/bots/recipes/swarm_trigger.py (right):

https://codereview.chromium.org/2263323002/diff/280001/infra/bots/recipes/swa...
infra/bots/recipes/swarm_trigger.py:484: upload_args.append(get_issue_num(api))
On 2016/08/23 19:04:37, rmistry wrote:
> On 2016/08/23 18:45:33, borenet wrote:
> > I'm just realizing that it's weird we don't include the patchset in the DM
or
> > nanobench results.  Not important to fix right now, but when we get to the
> point
> > where we want to show the test results for trybots before submitting the CL,
> the
> > patchset is going to be important.
> 
> We do include the patchset in the DM and nanobench JSON file via properties in
> swarm_test and swarm_perf. This is just the Google Storage path where the JSON
> file is stored. I found out today that the path is not really used to
determine
> the issue and patchset but the JSON file is. Also I am not sure what happens
> when new results come in from a different patchset and things are overridden
> within the hour.

Gotcha.

[rmistry, 2016-08-24 11:31:33]

The CQ bit was checked by rmistry@google.com

[commit-bot: I haz the power, 2016-08-24 11:31:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 12:07:08]

Description was changed from

==========
Apply gerrit ref if it is a Gerrit patch.

Also:
* Pass through a new property 'patch_storage' to DM/Nanobench/Coverage. This
will be used by the different frameworks to figure out if it is Rietveld or
Gerrit issue.
* Calculate issue and patchset for Gerrit patches similar to Rietveld.

BUG=skia:5627
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2263323002
==========

to

==========
Apply gerrit ref if it is a Gerrit patch.

Also:
* Pass through a new property 'patch_storage' to DM/Nanobench/Coverage. This
will be used by the different frameworks to figure out if it is Rietveld or
Gerrit issue.
* Calculate issue and patchset for Gerrit patches similar to Rietveld.

BUG=skia:5627
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2263323002

Committed:
https://skia.googlesource.com/skia/+/3f1c9c0a7227d4ea45c39eb1e596538bb483f65a
==========

[commit-bot: I haz the power, 2016-08-24 12:07:09]

Committed patchset #9 (id:280001) as
https://skia.googlesource.com/skia/+/3f1c9c0a7227d4ea45c39eb1e596538bb483f65a