Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Side by Side Diff: infra/bots/recipes/swarm_compile.py

Issue 2263323002: Apply gerrit ref if it is a Gerrit patch (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: Cleanup Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 5
6 # Recipe module for Skia Swarming compile. 6 # Recipe module for Skia Swarming compile.
7 7
8 8
9 DEPS = [ 9 DEPS = [
10 'core', 10 'core',
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 werr = False 100 werr = False
101 if 'Win' in builder_dict.get('os', ''): 101 if 'Win' in builder_dict.get('os', ''):
102 if not ('GDI' in builder_dict.get('extra_config', '') or 102 if not ('GDI' in builder_dict.get('extra_config', '') or
103 'Exceptions' in builder_dict.get('extra_config', '')): 103 'Exceptions' in builder_dict.get('extra_config', '')):
104 werr = True 104 werr = True
105 elif ('Mac' in builder_dict.get('os', '') and 105 elif ('Mac' in builder_dict.get('os', '') and
106 'Android' in builder_dict.get('extra_config', '')): 106 'Android' in builder_dict.get('extra_config', '')):
107 werr = False 107 werr = False
108 elif 'Fast' in builder_dict.get('extra_config', ''): 108 elif 'Fast' in builder_dict.get('extra_config', ''):
109 # See https://bugs.chromium.org/p/skia/issues/detail?id=5257 109 # See https://bugs.chromium.org/p/skia/issues/detail?id=5257
110 werr = False 110 werr = False
111 else: 111 else:
112 werr = True 112 werr = True
113 gyp_defs['skia_warnings_as_errors'] = str(int(werr)) # True/False -> '1'/'0' 113 gyp_defs['skia_warnings_as_errors'] = str(int(werr)) # True/False -> '1'/'0'
114 114
115 # Win debugger. 115 # Win debugger.
116 if 'Win' in builder_dict.get('os', ''): 116 if 'Win' in builder_dict.get('os', ''):
117 gyp_defs['skia_win_debuggers_path'] = 'c:/DbgHelp' 117 gyp_defs['skia_win_debuggers_path'] = 'c:/DbgHelp'
118 118
119 # Qt SDK (Win). 119 # Qt SDK (Win).
120 if 'Win' in builder_dict.get('os', ''): 120 if 'Win' in builder_dict.get('os', ''):
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
302 path_config='kitchen', 302 path_config='kitchen',
303 swarm_out_dir='[SWARM_OUT_DIR]', 303 swarm_out_dir='[SWARM_OUT_DIR]',
304 rietveld='https://codereview.chromium.org', 304 rietveld='https://codereview.chromium.org',
305 patchset=1, 305 patchset=1,
306 issue=2147533002L) + 306 issue=2147533002L) +
307 api.path.exists( 307 api.path.exists(
308 api.path['slave_build'].join('tmp', 'uninteresting_hashes.txt') 308 api.path['slave_build'].join('tmp', 'uninteresting_hashes.txt')
309 ) + 309 ) +
310 api.platform('win', 64) 310 api.platform('win', 64)
311 ) 311 )
312
313 gerrit_kwargs = {
314 'patch_storage': 'gerrit',
315 'repository': 'skia',
316 'event.patchSet.ref': 'refs/changes/00/2100/2',
317 'event.change.number': '2100',
318 }
319 yield (
320 api.test('recipe_with_gerrit_patch') +
321 api.properties(
322 buildername=buildername + '-Trybot',
323 mastername=mastername,
324 slavename=slavename,
325 buildnumber=5,
326 path_config='kitchen',
327 swarm_out_dir='[SWARM_OUT_DIR]',
328 revision='abc123',
329 **gerrit_kwargs) +
330 api.platform('win', 64)
331 )
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698