[interpreter] Make the binary op with Smi bytecode handlers collect type feedback.

src/interpreter/bytecode-array-builder.h

Index: src/interpreter/bytecode-array-builder.h
diff --git a/src/interpreter/bytecode-array-builder.h b/src/interpreter/bytecode-array-builder.h
index 51b61861c3636fa9aa31e5f3a6fe4b594b53dcde..38b6bc49f2b1b25b41c80090747fc38676e78196 100644
--- a/src/interpreter/bytecode-array-builder.h
+++ b/src/interpreter/bytecode-array-builder.h
@@ -217,6 +217,12 @@ class BytecodeArrayBuilder final : public ZoneObject {
   BytecodeArrayBuilder& BinaryOperation(Token::Value binop, Register reg,
                                         int feedback_slot);
 
+  // Operators (register holds the lhs value, accumulator holds the rhs value).
+  // Type feedback will be recorded in the |feedback_slot|
+  BytecodeArrayBuilder& BinaryOperationSmi(Token::Value binop,

[rmcilroy, 2016/08/23 13:31:17]

Please don't add this as a specific operation, it should only ever be emitted by
the peephole optimizer. You should be able to get the same result by emitting
the following code in the test:

builder()->LoadLiteral(test_case.arg1)
       .StoreAccumulatorInRegister(reg)
       .LoadLiteral(test_case.arg2)
       .BinaryOperation(test_case.op, reg, vector->GetIndex(slot0))

[epertoso, 2016/08/23 14:22:16]

Done.

+                                           int32_t smi_value, Register reg,
+                                           int feedback_slot);
+
   // Count Operators (value stored in accumulator).
   // Type feedback will be recorded in the |feedback_slot|
   BytecodeArrayBuilder& CountOperation(Token::Value op, int feedback_slot);
@@ -329,6 +335,7 @@ class BytecodeArrayBuilder final : public ZoneObject {
   friend class BytecodeRegisterAllocator;
 
   static Bytecode BytecodeForBinaryOperation(Token::Value op);
+  static Bytecode BytecodeForBinaryOperationSmi(Token::Value op);
   static Bytecode BytecodeForCountOperation(Token::Value op);
   static Bytecode BytecodeForCompareOperation(Token::Value op);
   static Bytecode BytecodeForStoreNamedProperty(LanguageMode language_mode);