[interpreter] Make the binary op with Smi bytecode handlers collect type feedback.

src/interpreter/bytecode-array-builder.h

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_INTERPRETER_BYTECODE_ARRAY_BUILDER_H_
 #define V8_INTERPRETER_BYTECODE_ARRAY_BUILDER_H_
 
 #include "src/ast/ast.h"
 #include "src/interpreter/bytecode-array-writer.h"
 #include "src/interpreter/bytecode-register-allocator.h"
@@ skipping 199 matching lines @@
   // be in |receiver_args| and all subsequent arguments should be in registers
   // <receiver + 1> to <receiver + receiver_args_count - 1>.
   BytecodeArrayBuilder& CallJSRuntime(int context_index, Register receiver_args,
                                       size_t receiver_args_count);
 
   // Operators (register holds the lhs value, accumulator holds the rhs value).
   // Type feedback will be recorded in the |feedback_slot|
   BytecodeArrayBuilder& BinaryOperation(Token::Value binop, Register reg,
                                         int feedback_slot);
 
+  // Operators (register holds the lhs value, accumulator holds the rhs value).
+  // Type feedback will be recorded in the |feedback_slot|
+  BytecodeArrayBuilder& BinaryOperationSmi(Token::Value binop,

[rmcilroy, 2016/08/23 13:31:17]

Please don't add this as a specific operation, it should only ever be emitted by
the peephole optimizer. You should be able to get the same result by emitting
the following code in the test:

builder()->LoadLiteral(test_case.arg1)
       .StoreAccumulatorInRegister(reg)
       .LoadLiteral(test_case.arg2)
       .BinaryOperation(test_case.op, reg, vector->GetIndex(slot0))

[epertoso, 2016/08/23 14:22:16]

Done.

+                                           int32_t smi_value, Register reg,
+                                           int feedback_slot);
+
   // Count Operators (value stored in accumulator).
   // Type feedback will be recorded in the |feedback_slot|
   BytecodeArrayBuilder& CountOperation(Token::Value op, int feedback_slot);
 
   // Unary Operators.
   BytecodeArrayBuilder& LogicalNot();
   BytecodeArrayBuilder& TypeOf();
 
   // Deletes property from an object. This expects that accumulator contains
   // the key to be deleted and the register contains a reference to the object.
@@ skipping 92 matching lines @@
 
   static uint32_t UnsignedOperand(size_t value) {
     DCHECK_LE(value, kMaxUInt32);
     return static_cast<uint32_t>(value);
   }
 
  private:
   friend class BytecodeRegisterAllocator;
 
   static Bytecode BytecodeForBinaryOperation(Token::Value op);
+  static Bytecode BytecodeForBinaryOperationSmi(Token::Value op);
   static Bytecode BytecodeForCountOperation(Token::Value op);
   static Bytecode BytecodeForCompareOperation(Token::Value op);
   static Bytecode BytecodeForStoreNamedProperty(LanguageMode language_mode);
   static Bytecode BytecodeForStoreKeyedProperty(LanguageMode language_mode);
   static Bytecode BytecodeForLoadGlobal(TypeofMode typeof_mode);
   static Bytecode BytecodeForStoreGlobal(LanguageMode language_mode);
   static Bytecode BytecodeForStoreLookupSlot(LanguageMode language_mode);
   static Bytecode BytecodeForCreateArguments(CreateArgumentsType type);
   static Bytecode BytecodeForDelete(LanguageMode language_mode);
   static Bytecode BytecodeForCall(TailCallMode tail_call_mode);
@@ skipping 59 matching lines @@
   BytecodeSourceInfo latest_source_info_;
 
   DISALLOW_COPY_AND_ASSIGN(BytecodeArrayBuilder);
 };
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_INTERPRETER_BYTECODE_ARRAY_BUILDER_H_