Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 226323002: [CSS Shapes] Remove outside-shape CSS value (Closed)

Created:
6 years, 8 months ago by rwlbuis
Modified:
6 years, 8 months ago
CC:
blink-reviews, zoltan1, dsinclair, bemjb+rendering_chromium.org, eae+blinkwatch, ed+blinkwatch_opera.com, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, pdr., rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[CSS Shapes] Remove outside-shape CSS value Outside-shape is not a valid CSS value anymore. This patch removes it. This is a merge of http://trac.webkit.org/changeset/166786 by Zoltan Horvath <zoltan@webkit.org>;. BUG=360098 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170910

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -23 lines) Patch
M LayoutTests/fast/shapes/parsing/parsing-shape-outside.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/shapes/parsing/parsing-shape-outside-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSValueKeywords.in View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/shapes/ShapeInfo.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/shapes/ShapeOutsideInfo.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/style/ShapeValue.h View 3 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
rwlbuis
PTAL
6 years, 8 months ago (2014-04-04 18:38:19 UTC) #1
Zoltan
lgtm
6 years, 8 months ago (2014-04-04 18:40:43 UTC) #2
Zoltan
lgtm
6 years, 8 months ago (2014-04-04 18:40:45 UTC) #3
rwlbuis
PTAL, more removing of leftovers.
6 years, 8 months ago (2014-04-04 18:42:40 UTC) #4
eseidel
lgtm zap!
6 years, 8 months ago (2014-04-04 21:18:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/226323002/1
6 years, 8 months ago (2014-04-04 21:18:37 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-04 21:20:47 UTC) #7
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-04-04 21:20:47 UTC) #8
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 8 months ago (2014-04-04 21:23:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/226323002/1
6 years, 8 months ago (2014-04-04 21:23:21 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-04 21:28:40 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 8 months ago (2014-04-04 21:28:40 UTC) #12
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 8 months ago (2014-04-04 21:37:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/226323002/1
6 years, 8 months ago (2014-04-04 21:38:52 UTC) #14
commit-bot: I haz the power
6 years, 8 months ago (2014-04-04 22:31:25 UTC) #15
Message was sent while issue was closed. 
Change committed as 170910

Powered by Google App Engine
This is Rietveld 408576698