Source/core/rendering/shapes/ShapeInfo.cpp - Issue 226323002: [CSS Shapes] Remove outside-shape CSS value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/shapes/ShapeInfo.cpp

Issue 226323002: [CSS Shapes] Remove outside-shape CSS value (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/shapes/ShapeInfo.cpp

diff --git a/Source/core/rendering/shapes/ShapeInfo.cpp b/Source/core/rendering/shapes/ShapeInfo.cpp

index 22879e8f8f84a3b3abcedfb380eec05d93737a5d..9260dcf2d0d9d8e96e25cad16bc797f0d0b7fdcf 100644

--- a/Source/core/rendering/shapes/ShapeInfo.cpp

+++ b/Source/core/rendering/shapes/ShapeInfo.cpp

@@ -135,9 +135,6 @@ const Shape& ShapeInfo<RenderType>::computedShape() const

m_shape = Shape::createLayoutBoxShape(shapeRect, writingMode, margin);

break;

}

- case ShapeValue::Outside:

- // Outside should have already resolved to a different shape value.

- ASSERT_NOT_REACHED();

}

ASSERT(m_shape);