Issue 2262913002: fix TranslateBubble toggle off by omnibar icon

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2262913002: fix TranslateBubble toggle off by omnibar icon

Created:
4 years, 4 months ago by ftang

Modified:
4 years, 3 months ago

Reviewers:
groby-ooo-7-16

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

fix TranslateBubble toggle off by omnibar icon BUG=636637

Patch Set 1 #

Patch Set 2 : fix comment #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -17 lines)			Patch
M	chrome/browser/ui/cocoa/browser_window_controller.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_controller.mm	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/translate/translate_bubble_controller_unittest.mm	View		1 chunk	+18 lines, -17 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ftang

I know this is very hacky. But this is the only way I can reliable ...

4 years, 4 months ago (2016-08-20 08:13:09 UTC) #2

groby-ooo-7-16

4 years, 3 months ago (2016-09-09 23:14:46 UTC) #3

On 2016/08/20 08:13:09, ftang wrote:
> I know this is very hacky. But this is the only way I can reliable make the
icon
> toggle off correctly without crash so far......

You're not still actively working on this one, right? We can close it?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages