Chromium Code Reviews| Index: chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc |
| diff --git a/chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc b/chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc |
| index b0e45cd16a12ce12b4365a791788143bf3aa5041..3f863fa542b23c1888718a236d22832339b48c6d 100644 |
| --- a/chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc |
| +++ b/chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc |
| @@ -100,15 +100,6 @@ const char* kBrowserSupportedExtensions[] = { |
| ".mhtml", ".mht", ".svg" |
| }; |
| -// List of all extensions we want to be shown in histogram that keep track of |
| -// files that were unsuccessfully tried to be opened. |
| -// The list has to be synced with histogram values. |
| -const char* kUMATrackingExtensions[] = { |
| - "other", ".doc", ".docx", ".odt", ".rtf", ".pdf", ".ppt", ".pptx", ".odp", |
| - ".xls", ".xlsx", ".ods", ".csv", ".odf", ".rar", ".asf", ".wma", ".wmv", |
| - ".mov", ".mpg", ".log" |
| -}; |
| - |
| // Returns a file manager URL for the given |path|. |
| GURL GetFileManagerUrl(const char* path) { |
| return GURL(std::string("chrome-extension://") + kFileBrowserDomain + path); |
| @@ -156,19 +147,6 @@ bool IsFlashPluginEnabled(Profile* profile) { |
| return IsPepperPluginEnabled(profile, plugin_path); |
| } |
| -// Returns index |ext| has in the |array|. If there is no |ext| in |array|, last |
| -// element's index is return (last element should have irrelevant value). |
| -int UMAExtensionIndex(const char *file_extension, |
| - const char** array, |
| - size_t array_size) { |
| - for (size_t i = 0; i < array_size; i++) { |
| - if (base::strcasecmp(file_extension, array[i]) == 0) { |
| - return i; |
| - } |
| - } |
| - return 0; |
| -} |
| - |
| // Convert numeric dialog type to a string. |
| std::string GetDialogTypeAsString( |
| ui::SelectFileDialog::Type dialog_type) { |
| @@ -810,13 +788,8 @@ bool ExecuteBuiltinHandler(Browser* browser, const base::FilePath& path) { |
| return true; |
| } |
| - // Unknown file type. Record UMA and show an error message. |
| - size_t extension_index = UMAExtensionIndex(file_extension.data(), |
| - kUMATrackingExtensions, |
| - arraysize(kUMATrackingExtensions)); |
| - UMA_HISTOGRAM_ENUMERATION("FileBrowser.OpeningFileType", |
| - extension_index, |
| - arraysize(kUMATrackingExtensions) - 1); |
| + // Failed to open the unknown file type. |
|
mtomasz
2013/08/12 06:47:41
nit: unknown file type -> unknown type file.
satorux1
2013/08/12 06:56:08
Done.
|
| + LOG(WARNING) << "Unknown file type: " << path.value(); |
| return false; |
| } |