file_manager: Remove FileBrowser.OpeningFileType histogram

chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 #include "chrome/browser/chromeos/extensions/file_manager/file_manager_util.h"
 
 #include "ash/shell.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/json/json_writer.h"
 #include "base/logging.h"
@@ skipping 82 matching lines @@
 const char kSwfExtension[] = ".swf";
 // List of file extension we can open in tab.
 const char* kBrowserSupportedExtensions[] = {
 #if defined(GOOGLE_CHROME_BUILD)
     ".pdf", ".swf",
 #endif
     ".bmp", ".jpg", ".jpeg", ".png", ".webp", ".gif", ".txt", ".html", ".htm",
     ".mhtml", ".mht", ".svg"
 };
 
-// List of all extensions we want to be shown in histogram that keep track of
-// files that were unsuccessfully tried to be opened.
-// The list has to be synced with histogram values.
-const char* kUMATrackingExtensions[] = {
-  "other", ".doc", ".docx", ".odt", ".rtf", ".pdf", ".ppt", ".pptx", ".odp",
-  ".xls", ".xlsx", ".ods", ".csv", ".odf", ".rar", ".asf", ".wma", ".wmv",
-  ".mov", ".mpg", ".log"
-};
-
 // Returns a file manager URL for the given |path|.
 GURL GetFileManagerUrl(const char* path) {
   return GURL(std::string("chrome-extension://") + kFileBrowserDomain + path);
 }
 
 bool IsSupportedBrowserExtension(const char* file_extension) {
   for (size_t i = 0; i < arraysize(kBrowserSupportedExtensions); i++) {
     if (base::strcasecmp(file_extension, kBrowserSupportedExtensions[i]) == 0) {
       return true;
     }
@@ skipping 27 matching lines @@
 
 bool IsFlashPluginEnabled(Profile* profile) {
   base::FilePath plugin_path(
       CommandLine::ForCurrentProcess()->GetSwitchValueNative(
           switches::kPpapiFlashPath));
   if (plugin_path.empty())
     PathService::Get(chrome::FILE_PEPPER_FLASH_PLUGIN, &plugin_path);
   return IsPepperPluginEnabled(profile, plugin_path);
 }
 
-// Returns index |ext| has in the |array|. If there is no |ext| in |array|, last
-// element's index is return (last element should have irrelevant value).
-int UMAExtensionIndex(const char *file_extension,
-                      const char** array,
-                      size_t array_size) {
-  for (size_t i = 0; i < array_size; i++) {
-    if (base::strcasecmp(file_extension, array[i]) == 0) {
-      return i;
-    }
-  }
-  return 0;
-}
-
 // Convert numeric dialog type to a string.
 std::string GetDialogTypeAsString(
     ui::SelectFileDialog::Type dialog_type) {
   std::string type_str;
   switch (dialog_type) {
     case ui::SelectFileDialog::SELECT_NONE:
       type_str = "full-page";
       break;
 
     case ui::SelectFileDialog::SELECT_FOLDER:
@@ skipping 621 matching lines @@
         return false;
       integration_service->file_system()->GetFileByPath(
           drive::util::ExtractDrivePath(path),
           base::Bind(&OnCRXDownloadCallback, browser));
     } else {
       InstallCRX(browser, path);
     }
     return true;
   }
 
-  // Unknown file type. Record UMA and show an error message.
-  size_t extension_index = UMAExtensionIndex(file_extension.data(),
-                                             kUMATrackingExtensions,
-                                             arraysize(kUMATrackingExtensions));
-  UMA_HISTOGRAM_ENUMERATION("FileBrowser.OpeningFileType",
-                            extension_index,
-                            arraysize(kUMATrackingExtensions) - 1);
+  // Failed to open the unknown file type.

[mtomasz, 2013/08/12 06:47:41]

nit: unknown file type -> unknown type file.

[satorux1, 2013/08/12 06:56:08]

Done.

+  LOG(WARNING) << "Unknown file type: " << path.value();
   return false;
 }
 
 // If a bundled plugin is enabled, we should open pdf/swf files in a tab.
 bool ShouldBeOpenedWithPlugin(Profile* profile, const char* file_extension) {
   if (LowerCaseEqualsASCII(file_extension, kPdfExtension))
     return IsPdfPluginEnabled(profile);
   if (LowerCaseEqualsASCII(file_extension, kSwfExtension))
     return IsFlashPluginEnabled(profile);
   return false;
@@ skipping 14 matching lines @@
     // determined, then indicate that it has the empty mime-type. This will
     // only be matched if the Web Intents accepts "*" or "*/*".
     return "";
   } else {
     return mime_type;
   }
 }
 
 }  // namespace util
 }  // namespace file_manager