Issue 22629012: file_manager: Remove FileBrowser.OpeningFileType histogram

Issue 22629012: file_manager: Remove FileBrowser.OpeningFileType histogram (Closed)

Created:
7 years, 4 months ago by satorux1

Modified:
7 years, 4 months ago

Reviewers:
mtomasz

CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

file_manager: Remove FileBrowser.OpeningFileType histogram This histogram has been replaced by FileBrowser.ViewingFileType. In fact, this histogram is marked <obsolete> in tools/metrics/histograms/histograms.xml BUG=189103 TEST=none R=mtomasz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216952

Patch Set 1 : #

Total comments: 2

Patch Set 2 : address comments #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -29 lines)			Patch
	M	chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc	View	1	3 chunks	+2 lines, -29 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

mtomasz

lgtm with a nit https://codereview.chromium.org/22629012/diff/3001/chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc File chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc (right): https://codereview.chromium.org/22629012/diff/3001/chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc#newcode791 chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc:791: // Failed to open the ...

7 years, 4 months ago (2013-08-12 06:47:41 UTC) #2

satorux1

https://codereview.chromium.org/22629012/diff/3001/chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc File chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc (right): https://codereview.chromium.org/22629012/diff/3001/chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc#newcode791 chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc:791: // Failed to open the unknown file type. On ...

7 years, 4 months ago (2013-08-12 06:56:08 UTC) #3

satorux1

7 years, 4 months ago (2013-08-12 07:30:12 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r216952 (presubmit successful).

Expand Messages | Collapse Messages