Issue 22629011: Fix overflow check computation for Smi Phis

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22629011: Fix overflow check computation for Smi Phis (Closed)

Created:
7 years, 4 months ago by Jakob Kummerow

Modified:
7 years, 4 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -13 lines)			Patch
	M	src/hydrogen-representation-changes.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	A +	test/mjsunit/regress/regress-2836.js	View		1 chunk	+5 lines, -12 lines	0 comments	Download

Total messages: 3 (0 generated)

Toon Verwaest

LGTM, thanks for fixing this. Smi truncation + integer32 truncation needs work.

7 years, 4 months ago (2013-08-10 13:48:22 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r16180.