src/hydrogen-representation-changes.cc - Issue 22629011: Fix overflow check computation for Smi Phis

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen-representation-changes.cc

Issue 22629011: Fix overflow check computation for Smi Phis (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen-representation-changes.cc

diff --git a/src/hydrogen-representation-changes.cc b/src/hydrogen-representation-changes.cc

index 63b7b4d6ec8e326a2900e1be3c8b4557fabe70f5..ddb206ccaf561b90f98e145db247bba99e0924ae 100644

--- a/src/hydrogen-representation-changes.cc

+++ b/src/hydrogen-representation-changes.cc

@@ -127,7 +127,7 @@ void HRepresentationChangesPhase::Run() {

!(input_representation.IsInteger32() &&

use->CheckFlag(HValue::kTruncatingToInt32))) ||

(phi->representation().IsSmi() &&

- !(input_representation.IsSmi() ||

+ !(input_representation.IsSmi() &&

use->CheckFlag(HValue::kTruncatingToSmi)))) {

if (FLAG_trace_representation) {

PrintF("#%d Phi is not truncating because of #%d %s\n",

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-2836.js » ('j') | no next file with comments »