Issue 22629005: Add a performance assert that we do not emit a null check for smi class-ids. Instead we should use …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22629005: Add a performance assert that we do not emit a null check for smi class-ids. Instead we should use … (Closed)

Created:
7 years, 4 months ago by srdjan

Modified:
7 years, 4 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, Vyacheslav Egorov (Google), vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Add a performance assert that we do not emit a null check for smi class-ids. Instead we should use CheckSmiInstr which does a bit test. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=25928

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	runtime/vm/intermediate_language.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

srdjan

7 years, 4 months ago (2013-08-08 16:19:26 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r25928 (presubmit successful).