runtime/vm/intermediate_language.cc - Issue 22629005: Add a performance assert that we do not emit a null check for smi class-ids. Instead we should use …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language.cc

Issue 22629005: Add a performance assert that we do not emit a null check for smi class-ids. Instead we should use … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language.cc

===================================================================

--- runtime/vm/intermediate_language.cc (revision 25926)

+++ runtime/vm/intermediate_language.cc (working copy)

@@ -133,6 +133,8 @@

}

CompileType* in_type = value()->Type();

const intptr_t cid = unary_checks().GetCidAt(0);

+ // Performance check: use CheckSmiInstr instead.

+ ASSERT(cid != kSmiCid);

return in_type->is_nullable() && (in_type->ToNullableCid() == cid);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »