Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Unified Diff: base/android/jni_generator/jni_generator.py

Issue 2262883002: Handle @Annotated parameters when generating JNI headers from Java. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: x Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/android/jni_generator/jni_generator.py
diff --git a/base/android/jni_generator/jni_generator.py b/base/android/jni_generator/jni_generator.py
index 4e700feab5e12dcd9983c80554a7c06d0ac53907..7982797266130f7553e241bc38ef20a3616c4b4c 100755
--- a/base/android/jni_generator/jni_generator.py
+++ b/base/android/jni_generator/jni_generator.py
@@ -356,8 +356,14 @@ class JniParams(object):
ret = []
for p in [p.strip() for p in params.split(',')]:
items = p.split(' ')
+
+ # Remove @Annotations from parameters.
+ if items[0][0] is '@':
PEConn 2016/08/23 15:30:12 It'd be really cool if we could do some magic that
Bernhard Bauer 2016/08/23 15:33:08 Hm, but we only use @IntDef enums, which are just
Torne 2016/08/23 15:40:03 I'd prefer "if items[0].startswith('@')" - and als
Bernhard Bauer 2016/08/25 10:29:05 OK, I'm now handling any number of annotations, bu
+ del items[0]
+
if 'final' in items:
items.remove('final')
+
param = Param(
datatype=items[0],
name=(items[1] if len(items) > 1 else 'p%s' % len(ret)),

Powered by Google App Engine
This is Rietveld 408576698