Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Unified Diff: base/android/jni_generator/java/src/org/chromium/example/jni_generator/SampleForTests.java

Issue 2262883002: Handle @Annotated parameters when generating JNI headers from Java. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: x Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/android/jni_generator/java/src/org/chromium/example/jni_generator/SampleForTests.java
diff --git a/base/android/jni_generator/java/src/org/chromium/example/jni_generator/SampleForTests.java b/base/android/jni_generator/java/src/org/chromium/example/jni_generator/SampleForTests.java
index 339f5f5bb729aa745e782f9757e364fea639e794..42d8e56bbf006b0e10c9bccf85b633884834aca6 100644
--- a/base/android/jni_generator/java/src/org/chromium/example/jni_generator/SampleForTests.java
+++ b/base/android/jni_generator/java/src/org/chromium/example/jni_generator/SampleForTests.java
@@ -165,6 +165,13 @@ class SampleForTests {
// String constants that look like comments don't confuse the generator:
private String mArrgh = "*/*";
+ private @interface SomeAnnotation {}
+
+ // The generator is not confused by @Annotated parameters.
+ @CalledByNative
+ void javaMethodWithAnnotatedParam(@SomeAnnotation int foo) {
+ }
+
// ---------------------------------------------------------------------------------------------
// Java fields which are accessed from C++ code only must be annotated with @AccessedByNative to
// prevent them being eliminated when unreferenced code is stripped.

Powered by Google App Engine
This is Rietveld 408576698