ImageDocumentParser should stop sending data to ImageResource once decoding fails.

ImageDocumentParser should stop sending data to ImageResource once decoding fails.

BUG=635448
TEST=WebFrameTest.ImageDocumentDecodeError

Committed: https://crrev.com/2fb53d05488ff879e38553839f174f15af2af39b
Cr-Commit-Position: refs/heads/master@{#413539}

[Nate Chapin, 2016-08-19 20:58:29]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 20:59:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nate Chapin, 2016-08-22 18:26:39]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 18:33:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 21:06:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 21:06:19]

Dry run: This issue passed the CQ dry run.

[Nate Chapin, 2016-08-22 21:07:15]

japhet@chromium.org changed reviewers:
+ pdr@chromium.org

[Nate Chapin, 2016-08-22 21:07:15]

Hey pdr, up for a quick review? This is a followup to
https://codereview.chromium.org/2173873003, where I missed a case where we can
keep pumping data into ImageResource after decoding fails. ImageDocuments are
magic.

[pdr., 2016-08-22 21:19:40]

On 2016/08/22 at 21:07:15, japhet wrote:
> Hey pdr, up for a quick review? This is a followup to
https://codereview.chromium.org/2173873003, where I missed a case where we can
keep pumping data into ImageResource after decoding fails. ImageDocuments are
magic.

LGTM

[Nate Chapin, 2016-08-22 21:26:34]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2016-08-22 21:27:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 21:35:06]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-22 21:36:50]

Description was changed from

==========
ImageDocumentParser should stop sending data to ImageResource once decoding
fails.

BUG=635448
TEST=WebFrameTest.ImageDocumentDecodeError
==========

to

==========
ImageDocumentParser should stop sending data to ImageResource once decoding
fails.

BUG=635448
TEST=WebFrameTest.ImageDocumentDecodeError

Committed: https://crrev.com/2fb53d05488ff879e38553839f174f15af2af39b
Cr-Commit-Position: refs/heads/master@{#413539}
==========

[commit-bot: I haz the power, 2016-08-22 21:36:51]

Patchset 3 (id:??) landed as
https://crrev.com/2fb53d05488ff879e38553839f174f15af2af39b
Cr-Commit-Position: refs/heads/master@{#413539}

[megjablon, 2016-08-22 23:55:14]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2264333002/ by megjablon@chromium.org.

The reason for reverting is: Reverting due to webkit_unit_test failures on
builder "Mac ASan 64 Tests (1)":

https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests...

Output from
https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests...

[ RUN      ] WebFrameTest.ImageDocumentDecodeError
[       OK ] WebFrameTest.ImageDocumentDecodeError (87 ms)
[562/3806] WebFrameTest.ImageDocumentDecodeError (87 ms)
[ RUN      ] CompositedSelectionBoundsTest.None
ASAN:DEADLYSIGNAL
=================================================================
==91966==ERROR: AddressSanitizer: SEGV on unknown address 0x000045e0360e (pc
0x000045e0360e bp 0x7fff5f436950 sp 0x7fff5f436398 T0)
==91966==The signal is caused by a READ memory access.
    #0 0x45e0360d in
Traceback (most recent call last):
  File "/b/swarm_slave/w/irrExke3/tools/valgrind/asan/asan_symbolize.py", line
271, in <module>
    main()
  File "/b/swarm_slave/w/irrExke3/tools/valgrind/asan/asan_symbolize.py", line
268, in main
    loop.process_logfile()
  File
"/b/swarm_slave/w/irrExke3/tools/valgrind/asan/third_party/asan_symbolize.py",
line 416, in process_logfile
    processed = self.process_line(line)
  File
"/b/swarm_slave/w/irrExke3/tools/valgrind/asan/third_party/asan_symbolize.py",
line 439, in process_line_posix
    symbolized_line = self.symbolize_address(addr, binary, offset)
  File
"/b/swarm_slave/w/irrExke3/tools/valgrind/asan/third_party/asan_symbolize.py",
line 393, in symbolize_address
    result = symbolizers[binary].symbolize(addr, binary, offset)
  File
"/b/swarm_slave/w/irrExke3/tools/valgrind/asan/third_party/asan_symbolize.py",
line 244, in symbolize
    result = symbolizer.symbolize(addr, binary, offset)
  File
"/b/swarm_slave/w/irrExke3/tools/valgrind/asan/third_party/asan_symbolize.py",
line 216, in symbolize
    atos_line = self.atos.convert('0x%x' % int(offset, 16))
  File
"/b/swarm_slave/w/irrExke3/tools/valgrind/asan/third_party/asan_symbolize.py",
line 192, in convert
    self.w.write(line + "\n")
IOError: [Errno 5] Input/output error.