Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3475)

Unified Diff: chrome/browser/plugins/plugin_metadata.h

Issue 2262713003: Consistently use namespaced base::Version in plugins code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/plugins/plugin_finder.cc ('k') | chrome/browser/plugins/plugin_metadata.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/plugins/plugin_metadata.h
diff --git a/chrome/browser/plugins/plugin_metadata.h b/chrome/browser/plugins/plugin_metadata.h
index d54afd07f75b8c3f1ffd879f7a870762125fba2b..0fa927350ecc74c7c210d200ce47a03a6be99ed0 100644
--- a/chrome/browser/plugins/plugin_metadata.h
+++ b/chrome/browser/plugins/plugin_metadata.h
@@ -71,7 +71,7 @@ class PluginMetadata {
void AddMatchingMimeType(const std::string& mime_type);
// Adds information about a plugin version.
- void AddVersion(const Version& version, SecurityStatus status);
+ void AddVersion(const base::Version& version, SecurityStatus status);
// Checks if |plugin| mime types match all |matching_mime_types_|.
// If there is no |matching_mime_types_|, |group_name_matcher_| is used
@@ -91,7 +91,7 @@ class PluginMetadata {
private:
struct VersionComparator {
- bool operator() (const Version& lhs, const Version& rhs) const;
+ bool operator()(const base::Version& lhs, const base::Version& rhs) const;
};
std::string identifier_;
@@ -101,7 +101,7 @@ class PluginMetadata {
GURL plugin_url_;
GURL help_url_;
std::string language_;
- std::map<Version, SecurityStatus, VersionComparator> versions_;
+ std::map<base::Version, SecurityStatus, VersionComparator> versions_;
std::vector<std::string> all_mime_types_;
std::vector<std::string> matching_mime_types_;
« no previous file with comments | « chrome/browser/plugins/plugin_finder.cc ('k') | chrome/browser/plugins/plugin_metadata.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698