chrome/browser/plugins/plugin_finder.cc - Issue 2262713003: Consistently use namespaced base::Version in plugins code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/plugins/plugin_finder.cc

Issue 2262713003: Consistently use namespaced base::Version in plugins code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/plugins/plugin_finder.cc

diff --git a/chrome/browser/plugins/plugin_finder.cc b/chrome/browser/plugins/plugin_finder.cc

index e9902abcdb7e467d27aa167acb8499b708f193b9..d45eb13de3af43b1ff7edd2c8de511848d495702 100644

--- a/chrome/browser/plugins/plugin_finder.cc

+++ b/chrome/browser/plugins/plugin_finder.cc

@@ -138,7 +138,7 @@ PluginMetadata* CreatePluginMetadata(

PluginMetadata::SECURITY_STATUS_UP_TO_DATE;

success = PluginMetadata::ParseSecurityStatus(status_str, &status);

DCHECK(success);

- plugin->AddVersion(Version(version), status);

+ plugin->AddVersion(base::Version(version), status);

}

« no previous file with comments | « no previous file | chrome/browser/plugins/plugin_metadata.h » ('j') | no next file with comments »