Issue 2262713003: Consistently use namespaced base::Version in plugins code.

Issue 2262713003: Consistently use namespaced base::Version in plugins code. (Closed)

Created:
4 years, 4 months ago by pwnall

Modified:
4 years, 4 months ago

Reviewers:
brettw

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Consistently use namespaced base::Version in plugins code. BUG=639416 Committed: https://crrev.com/622e2f7265f311fd15f0a532c096eb507e737b34 Cr-Commit-Position: refs/heads/master@{#413508}

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -20 lines)			Patch
M	chrome/browser/plugins/plugin_finder.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/plugins/plugin_metadata.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/plugins/plugin_metadata.cc	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/plugins/plugin_metadata_unittest.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/common/pepper_flash.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/plugin_data_remover_impl.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/common/webplugininfo_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/common/webplugininfo.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 13 (7 generated)

brettw

Thanks! I hope we can eventually clean all of these up and remove the using ...

4 years, 4 months ago (2016-08-22 17:51:28 UTC) #7

pwnall

On 2016/08/22 17:51:28, brettw (ping on IM after 24h) wrote: > Thanks! I hope we ...

4 years, 4 months ago (2016-08-22 18:31:50 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2262713003/1

4 years, 4 months ago (2016-08-22 18:33:36 UTC) #10

commit-bot: I haz the power

4 years, 4 months ago (2016-08-22 19:43:34 UTC) #13

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/622e2f7265f311fd15f0a532c096eb507e737b34
Cr-Commit-Position: refs/heads/master@{#413508}