[TurboFan] Ensure value is pushed for StackOverflow in AstVisitor::Visit.

[TurboFan] Ensure value is pushed for StackOverflow in AstVisitor::Visit.

AstGraphBuilder overrides Visit(Expression*) to ensure that even if there is a
stack overflow, a value still gets produced. However, if there was no stack
overflow in the overriden function, but calling
AstVisitor<AstGraphBuilder>::Visit(expr) pushes us over the stack limit, then
the stack overflow check in that function will return without visiting the
expression, and the result will never get pushed.

To fix this, we add a new VisitNoStackOverflowCheck function which avoids the
inner stack check, and call that instead.

Since this depends on the size of C++ stack frames, there is no reliable test
I can add, however regress-635429.js exibits this behavior after
https://codereview.chromium.org/2240463002/ lands.

Committed: https://crrev.com/c13acc815388aff94a5694ae9ad2587fa3cf42b2
Cr-Commit-Position: refs/heads/master@{#38774}

[rmcilroy, 2016-08-19 14:48:21]

Description was changed from

==========
[TurboFan] Ensure value is pushed for StackOverflow in AstVisitor::Visit.

AstGraphBuilder overrides Visit(Expression*) to ensure that even if there is a
stack overflow, a value still gets produced. However, if there was no stack
overflow in the overriden function, but calling
AstVisitor<AstGraphBuilder>::Visit(expr) pushes us over the stack limit, then
the stack overflow check in that function will return without visiting the
expression, and the result will never get pushed.

To fix this, we add a new VisitNoStackOverflowCheck function which avoids the
inner stack check, and call that instead.

Since this depends on the size of C++ stack frames, there is no reliable test
I can add, however regress-635429.js exibits this behavior after
https://codereview.chromium.org/2240463002/ lands.

BUG=
==========

to

==========
[TurboFan] Ensure value is pushed for StackOverflow in AstVisitor::Visit.

AstGraphBuilder overrides Visit(Expression*) to ensure that even if there is a
stack overflow, a value still gets produced. However, if there was no stack
overflow in the overriden function, but calling
AstVisitor<AstGraphBuilder>::Visit(expr) pushes us over the stack limit, then
the stack overflow check in that function will return without visiting the
expression, and the result will never get pushed.

To fix this, we add a new VisitNoStackOverflowCheck function which avoids the
inner stack check, and call that instead.

Since this depends on the size of C++ stack frames, there is no reliable test
I can add, however regress-635429.js exibits this behavior after
https://codereview.chromium.org/2240463002/ lands.
==========

[rmcilroy, 2016-08-19 14:48:33]

rmcilroy@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[rmcilroy, 2016-08-19 14:48:33]

Michi, PTAL, thanks.

[rmcilroy, 2016-08-19 14:49:41]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 14:49:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 15:14:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 15:14:33]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2016-08-22 07:29:33]

LGTM. Nice catch!

[rmcilroy, 2016-08-22 09:49:44]

The CQ bit was checked by rmcilroy@chromium.org

[commit-bot: I haz the power, 2016-08-22 09:49:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 10:27:55]

Description was changed from

==========
[TurboFan] Ensure value is pushed for StackOverflow in AstVisitor::Visit.

AstGraphBuilder overrides Visit(Expression*) to ensure that even if there is a
stack overflow, a value still gets produced. However, if there was no stack
overflow in the overriden function, but calling
AstVisitor<AstGraphBuilder>::Visit(expr) pushes us over the stack limit, then
the stack overflow check in that function will return without visiting the
expression, and the result will never get pushed.

To fix this, we add a new VisitNoStackOverflowCheck function which avoids the
inner stack check, and call that instead.

Since this depends on the size of C++ stack frames, there is no reliable test
I can add, however regress-635429.js exibits this behavior after
https://codereview.chromium.org/2240463002/ lands.
==========

to

==========
[TurboFan] Ensure value is pushed for StackOverflow in AstVisitor::Visit.

AstGraphBuilder overrides Visit(Expression*) to ensure that even if there is a
stack overflow, a value still gets produced. However, if there was no stack
overflow in the overriden function, but calling
AstVisitor<AstGraphBuilder>::Visit(expr) pushes us over the stack limit, then
the stack overflow check in that function will return without visiting the
expression, and the result will never get pushed.

To fix this, we add a new VisitNoStackOverflowCheck function which avoids the
inner stack check, and call that instead.

Since this depends on the size of C++ stack frames, there is no reliable test
I can add, however regress-635429.js exibits this behavior after
https://codereview.chromium.org/2240463002/ lands.
==========

[commit-bot: I haz the power, 2016-08-22 10:27:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-22 10:28:11]

Description was changed from

==========
[TurboFan] Ensure value is pushed for StackOverflow in AstVisitor::Visit.

AstGraphBuilder overrides Visit(Expression*) to ensure that even if there is a
stack overflow, a value still gets produced. However, if there was no stack
overflow in the overriden function, but calling
AstVisitor<AstGraphBuilder>::Visit(expr) pushes us over the stack limit, then
the stack overflow check in that function will return without visiting the
expression, and the result will never get pushed.

To fix this, we add a new VisitNoStackOverflowCheck function which avoids the
inner stack check, and call that instead.

Since this depends on the size of C++ stack frames, there is no reliable test
I can add, however regress-635429.js exibits this behavior after
https://codereview.chromium.org/2240463002/ lands.
==========

to

==========
[TurboFan] Ensure value is pushed for StackOverflow in AstVisitor::Visit.

AstGraphBuilder overrides Visit(Expression*) to ensure that even if there is a
stack overflow, a value still gets produced. However, if there was no stack
overflow in the overriden function, but calling
AstVisitor<AstGraphBuilder>::Visit(expr) pushes us over the stack limit, then
the stack overflow check in that function will return without visiting the
expression, and the result will never get pushed.

To fix this, we add a new VisitNoStackOverflowCheck function which avoids the
inner stack check, and call that instead.

Since this depends on the size of C++ stack frames, there is no reliable test
I can add, however regress-635429.js exibits this behavior after
https://codereview.chromium.org/2240463002/ lands.

Committed: https://crrev.com/c13acc815388aff94a5694ae9ad2587fa3cf42b2
Cr-Commit-Position: refs/heads/master@{#38774}
==========

[commit-bot: I haz the power, 2016-08-22 10:28:12]

Patchset 2 (id:??) landed as
https://crrev.com/c13acc815388aff94a5694ae9ad2587fa3cf42b2
Cr-Commit-Position: refs/heads/master@{#38774}