Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: src/compiler/ast-graph-builder.cc

Issue 2262703002: [TurboFan] Ensure value is pushed for StackOverflow in AstVisitor::Visit. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast/ast.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/ast-graph-builder.cc
diff --git a/src/compiler/ast-graph-builder.cc b/src/compiler/ast-graph-builder.cc
index f0a138a74f5cd2b1318ee7cb49af7c13b2e6bc39..38b20213f7567283360a4d853258ad3f6b83f60d 100644
--- a/src/compiler/ast-graph-builder.cc
+++ b/src/compiler/ast-graph-builder.cc
@@ -1045,7 +1045,7 @@ void AstGraphBuilder::VisitForValues(ZoneList<Expression*>* exprs) {
void AstGraphBuilder::VisitForValue(Expression* expr) {
AstValueContext for_value(this);
if (!CheckStackOverflow()) {
- AstVisitor<AstGraphBuilder>::Visit(expr);
+ VisitNoStackOverflowCheck(expr);
} else {
ast_context()->ProduceValue(expr, jsgraph()->UndefinedConstant());
}
@@ -1055,7 +1055,7 @@ void AstGraphBuilder::VisitForValue(Expression* expr) {
void AstGraphBuilder::VisitForEffect(Expression* expr) {
AstEffectContext for_effect(this);
if (!CheckStackOverflow()) {
- AstVisitor<AstGraphBuilder>::Visit(expr);
+ VisitNoStackOverflowCheck(expr);
} else {
ast_context()->ProduceValue(expr, jsgraph()->UndefinedConstant());
}
@@ -1065,7 +1065,7 @@ void AstGraphBuilder::VisitForEffect(Expression* expr) {
void AstGraphBuilder::VisitForTest(Expression* expr) {
AstTestContext for_condition(this, expr->test_id());
if (!CheckStackOverflow()) {
- AstVisitor<AstGraphBuilder>::Visit(expr);
+ VisitNoStackOverflowCheck(expr);
} else {
ast_context()->ProduceValue(expr, jsgraph()->UndefinedConstant());
}
@@ -1075,7 +1075,7 @@ void AstGraphBuilder::VisitForTest(Expression* expr) {
void AstGraphBuilder::Visit(Expression* expr) {
// Reuses enclosing AstContext.
if (!CheckStackOverflow()) {
- AstVisitor<AstGraphBuilder>::Visit(expr);
+ VisitNoStackOverflowCheck(expr);
} else {
ast_context()->ProduceValue(expr, jsgraph()->UndefinedConstant());
}
« no previous file with comments | « src/ast/ast.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698