Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Unified Diff: net/url_request/url_request_job.h

Issue 2262653003: Make URLRequest::Read to return net errors or bytes read instead of a bool (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more fixes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_job.h
diff --git a/net/url_request/url_request_job.h b/net/url_request/url_request_job.h
index b93ff45d633c9330beaeb77f4772d3d8d5486245..0aa63bc9eb3e473659ea68f4abe4a2df70241b53 100644
--- a/net/url_request/url_request_job.h
+++ b/net/url_request/url_request_job.h
@@ -96,9 +96,11 @@ class NET_EXPORT URLRequestJob : public base::PowerObserver {
virtual void Kill();
// Called to read post-filtered data from this Job, returning the number of
- // bytes read, 0 when there is no more data, or -1 if there was an error.
- // This is just the backend for URLRequest::Read, see that function for
+ // bytes read, 0 when there is no more data, or net error if there was an
+ // error. This is just the backend for URLRequest::Read, see that function for
// more info.
+ int Read(IOBuffer* buf, int buf_size);
+ // Deprecated.
bool Read(IOBuffer* buf, int buf_size, int* bytes_read);
// Stops further caching of this request, if any. For more info, see

Powered by Google App Engine
This is Rietveld 408576698