Make URLRequest::Read to return net errors or bytes read instead of a bool

net/url_request/url_request_job.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_URL_REQUEST_URL_REQUEST_JOB_H_
 #define NET_URL_REQUEST_URL_REQUEST_JOB_H_
 
 #include <stdint.h>
 
 #include <memory>
@@ skipping 78 matching lines @@
   // this call, nor is it obliged to fail with "canceled" unless not all data
   // was sent as a result. A typical case would be where the job is almost
   // complete and can succeed before the canceled notification can be
   // dispatched (from the message loop).
   //
   // The job should be prepared to receive multiple calls to kill it, but only
   // one notification must be issued.
   virtual void Kill();
 
   // Called to read post-filtered data from this Job, returning the number of
-  // bytes read, 0 when there is no more data, or -1 if there was an error.
-  // This is just the backend for URLRequest::Read, see that function for
+  // bytes read, 0 when there is no more data, or net error if there was an
+  // error. This is just the backend for URLRequest::Read, see that function for
   // more info.
+  int Read(IOBuffer* buf, int buf_size);
+  // Deprecated.
   bool Read(IOBuffer* buf, int buf_size, int* bytes_read);
 
   // Stops further caching of this request, if any. For more info, see
   // URLRequest::StopCaching().
   virtual void StopCaching();
 
   virtual bool GetFullRequestHeaders(HttpRequestHeaders* headers) const;
 
   // Get the number of bytes received from network. The values returned by this
   // will never decrease over the lifetime of the URLRequestJob.
@@ skipping 347 matching lines @@
   int64_t last_notified_total_sent_bytes_;
 
   base::WeakPtrFactory<URLRequestJob> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(URLRequestJob);
 };
 
 }  // namespace net
 
 #endif  // NET_URL_REQUEST_URL_REQUEST_JOB_H_