Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: pkg/shelf/lib/src/response.dart

Issue 226263007: issue 17992 Added extra params to message (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: review updates. Renamed extraParams to context. Updated comment Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/shelf/lib/src/request.dart ('k') | pkg/shelf/test/request_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/shelf/lib/src/response.dart
diff --git a/pkg/shelf/lib/src/response.dart b/pkg/shelf/lib/src/response.dart
index 07eba1b4db4e360b59fbf1c04613a1c4c3fa34de..41e26e5b3e152cec4ccfe20656df3fb653d5c62a 100644
--- a/pkg/shelf/lib/src/response.dart
+++ b/pkg/shelf/lib/src/response.dart
@@ -54,8 +54,10 @@ class Response extends Message {
/// If [encoding] is passed, the "encoding" field of the Content-Type header
/// in [headers] will be set appropriately. If there is no existing
/// Content-Type header, it will be set to "application/octet-stream".
- Response.ok(body, {Map<String, String> headers, Encoding encoding})
- : this(200, body: body, headers: headers, encoding: encoding);
+ Response.ok(body, {Map<String, String> headers, Encoding encoding,
+ Map<String, Object> context})
+ : this(200, body: body, headers: headers, encoding: encoding,
+ context: context);
/// Constructs a 301 Moved Permanently response.
///
@@ -72,8 +74,9 @@ class Response extends Message {
/// in [headers] will be set appropriately. If there is no existing
/// Content-Type header, it will be set to "application/octet-stream".
Response.movedPermanently(location, {body, Map<String, String> headers,
- Encoding encoding})
- : this._redirect(301, location, body, headers, encoding);
+ Encoding encoding, Map<String, Object> context})
+ : this._redirect(301, location, body, headers, encoding,
+ context: context);
/// Constructs a 302 Found response.
///
@@ -90,8 +93,9 @@ class Response extends Message {
/// in [headers] will be set appropriately. If there is no existing
/// Content-Type header, it will be set to "application/octet-stream".
Response.found(location, {body, Map<String, String> headers,
- Encoding encoding})
- : this._redirect(302, location, body, headers, encoding);
+ Encoding encoding, Map<String, Object> context})
+ : this._redirect(302, location, body, headers, encoding,
+ context: context);
/// Constructs a 303 See Other response.
///
@@ -109,17 +113,20 @@ class Response extends Message {
/// in [headers] will be set appropriately. If there is no existing
/// Content-Type header, it will be set to "application/octet-stream".
Response.seeOther(location, {body, Map<String, String> headers,
- Encoding encoding})
- : this._redirect(303, location, body, headers, encoding);
+ Encoding encoding, Map<String, Object> context})
+ : this._redirect(303, location, body, headers, encoding,
+ context: context);
/// Constructs a helper constructor for redirect responses.
Response._redirect(int statusCode, location, body,
- Map<String, String> headers, Encoding encoding)
+ Map<String, String> headers, Encoding encoding,
+ { Map<String, Object> context })
: this(statusCode,
body: body,
encoding: encoding,
headers: _addHeader(
- headers, 'location', _locationToString(location)));
+ headers, 'location', _locationToString(location)),
+ context: context);
/// Constructs a 304 Not Modified response.
///
@@ -127,9 +134,11 @@ class Response extends Message {
/// information used to determine whether the requested resource has changed
/// since the last request. It indicates that the resource has not changed and
/// the old value should be used.
- Response.notModified({Map<String, String> headers})
+ Response.notModified({Map<String, String> headers,
+ Map<String, Object> context})
: this(304, headers: _addHeader(
- headers, 'date', formatHttpDate(new DateTime.now())));
+ headers, 'date', formatHttpDate(new DateTime.now())),
+ context: context);
/// Constructs a 403 Forbidden response.
///
@@ -144,8 +153,9 @@ class Response extends Message {
/// in [headers] will be set appropriately. If there is no existing
/// Content-Type header, it will be set to "application/octet-stream".
Response.forbidden(body, {Map<String, String> headers,
- Encoding encoding})
- : this(403, body: body, headers: headers);
+ Encoding encoding, Map<String, Object> context})
+ : this(403, body: body, headers: headers,
+ context: context);
/// Constructs a 404 Not Found response.
///
@@ -160,8 +170,10 @@ class Response extends Message {
/// If [encoding] is passed, the "encoding" field of the Content-Type header
/// in [headers] will be set appropriately. If there is no existing
/// Content-Type header, it will be set to "application/octet-stream".
- Response.notFound(body, {Map<String, String> headers, Encoding encoding})
- : this(404, body: body, headers: headers);
+ Response.notFound(body, {Map<String, String> headers, Encoding encoding,
+ Map<String, Object> context})
+ : this(404, body: body, headers: headers,
+ context: context);
/// Constructs a 500 Internal Server Error response.
///
@@ -177,10 +189,11 @@ class Response extends Message {
/// in [headers] will be set appropriately. If there is no existing
/// Content-Type header, it will be set to "application/octet-stream".
Response.internalServerError({body, Map<String, String> headers,
- Encoding encoding})
+ Encoding encoding, Map<String, Object> context})
: this(500,
headers: body == null ? _adjust500Headers(headers) : headers,
- body: body == null ? 'Internal Server Error' : body);
+ body: body == null ? 'Internal Server Error' : body,
+ context: context);
/// Constructs an HTTP response with the given [statusCode].
///
@@ -195,9 +208,12 @@ class Response extends Message {
/// in [headers] will be set appropriately. If there is no existing
/// Content-Type header, it will be set to "application/octet-stream".
Response(this.statusCode, {body, Map<String, String> headers,
- Encoding encoding})
+ Encoding encoding,
+ Map<String, Object> context})
: super(_adjustHeaders(headers, encoding),
- _bodyToStream(body, encoding)) {
+ _bodyToStream(body, encoding),
+ new UnmodifiableMapView(new Map.from(
+ context != null ? context: {}))) {
if (statusCode < 100) {
throw new ArgumentError("Invalid status code: $statusCode.");
}
« no previous file with comments | « pkg/shelf/lib/src/request.dart ('k') | pkg/shelf/test/request_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698