Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 226263002: Mojo: Move mojo/public/bindings to mojo/public/tools/bindings. (Closed)

Created:
6 years, 8 months ago by viettrungluu
Modified:
6 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, viettrungluu+watch_chromium.org, jam, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Mojo: Move mojo/public/bindings to mojo/public/tools/bindings. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261874

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -4321 lines) Patch
M content/content_common_mojo_bindings.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/mojo_examples.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/mojo_public.gypi View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/mojo_services.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
D mojo/public/bindings/generators/cpp_templates/enum_declaration.tmpl View 1 chunk +0 lines, -9 lines 0 comments Download
D mojo/public/bindings/generators/cpp_templates/interface_declaration.tmpl View 1 chunk +0 lines, -34 lines 0 comments Download
D mojo/public/bindings/generators/cpp_templates/interface_definition.tmpl View 1 chunk +0 lines, -223 lines 0 comments Download
D mojo/public/bindings/generators/cpp_templates/interface_macros.tmpl View 1 chunk +0 lines, -23 lines 0 comments Download
D mojo/public/bindings/generators/cpp_templates/interface_proxy_declaration.tmpl View 1 chunk +0 lines, -14 lines 0 comments Download
D mojo/public/bindings/generators/cpp_templates/interface_stub_declaration.tmpl View 1 chunk +0 lines, -12 lines 0 comments Download
D mojo/public/bindings/generators/cpp_templates/module-internal.h.tmpl View 1 1 chunk +0 lines, -41 lines 0 comments Download
D mojo/public/bindings/generators/cpp_templates/module.cc.tmpl View 1 1 chunk +0 lines, -68 lines 0 comments Download
D mojo/public/bindings/generators/cpp_templates/module.h.tmpl View 1 1 chunk +0 lines, -52 lines 0 comments Download
D mojo/public/bindings/generators/cpp_templates/params_definition.tmpl View 1 chunk +0 lines, -42 lines 0 comments Download
D mojo/public/bindings/generators/cpp_templates/struct_builder_definition.tmpl View 1 chunk +0 lines, -65 lines 0 comments Download
D mojo/public/bindings/generators/cpp_templates/struct_declaration.tmpl View 1 chunk +0 lines, -30 lines 0 comments Download
D mojo/public/bindings/generators/cpp_templates/struct_definition.tmpl View 1 chunk +0 lines, -53 lines 0 comments Download
D mojo/public/bindings/generators/cpp_templates/struct_destructor.tmpl View 1 chunk +0 lines, -11 lines 0 comments Download
D mojo/public/bindings/generators/cpp_templates/struct_macros.tmpl View 1 chunk +0 lines, -83 lines 0 comments Download
D mojo/public/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl View 1 chunk +0 lines, -87 lines 0 comments Download
D mojo/public/bindings/generators/js_templates/enum_definition.tmpl View 1 chunk +0 lines, -14 lines 0 comments Download
D mojo/public/bindings/generators/js_templates/interface_definition.tmpl View 1 chunk +0 lines, -114 lines 0 comments Download
D mojo/public/bindings/generators/js_templates/module.js.tmpl View 1 chunk +0 lines, -45 lines 0 comments Download
D mojo/public/bindings/generators/js_templates/struct_definition.tmpl View 1 chunk +0 lines, -118 lines 0 comments Download
D mojo/public/bindings/generators/mojom_cpp_generator.py View 1 chunk +0 lines, -219 lines 0 comments Download
D mojo/public/bindings/generators/mojom_js_generator.py View 1 chunk +0 lines, -227 lines 0 comments Download
D mojo/public/bindings/generators/run_cpp_generator.py View 1 chunk +0 lines, -28 lines 0 comments Download
D mojo/public/bindings/mojom_bindings_generator.gypi View 1 chunk +0 lines, -80 lines 0 comments Download
D mojo/public/bindings/mojom_bindings_generator.py View 1 chunk +0 lines, -142 lines 0 comments Download
D mojo/public/bindings/pylib/generate/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/public/bindings/pylib/generate/mojom.py View 1 chunk +0 lines, -188 lines 0 comments Download
D mojo/public/bindings/pylib/generate/mojom_data.py View 1 chunk +0 lines, -308 lines 0 comments Download
D mojo/public/bindings/pylib/generate/mojom_data_tests.py View 1 chunk +0 lines, -85 lines 0 comments Download
D mojo/public/bindings/pylib/generate/mojom_generator.py View 1 chunk +0 lines, -99 lines 0 comments Download
D mojo/public/bindings/pylib/generate/mojom_pack.py View 1 chunk +0 lines, -149 lines 0 comments Download
D mojo/public/bindings/pylib/generate/mojom_pack_tests.py View 1 chunk +0 lines, -174 lines 0 comments Download
D mojo/public/bindings/pylib/generate/mojom_test.py View 1 chunk +0 lines, -193 lines 0 comments Download
D mojo/public/bindings/pylib/generate/mojom_tests.py View 1 chunk +0 lines, -33 lines 0 comments Download
D mojo/public/bindings/pylib/generate/run_mojom_tests.py View 1 chunk +0 lines, -35 lines 0 comments Download
D mojo/public/bindings/pylib/generate/template_expander.py View 1 chunk +0 lines, -47 lines 0 comments Download
D mojo/public/bindings/pylib/parse/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/public/bindings/pylib/parse/mojo_lexer.py View 1 chunk +0 lines, -287 lines 0 comments Download
D mojo/public/bindings/pylib/parse/mojo_lexer_unittest.py View 1 chunk +0 lines, -159 lines 0 comments Download
D mojo/public/bindings/pylib/parse/mojo_parser.py View 1 1 chunk +0 lines, -371 lines 0 comments Download
D mojo/public/bindings/pylib/parse/mojo_parser_unittest.py View 1 chunk +0 lines, -231 lines 0 comments Download
D mojo/public/bindings/pylib/parse/mojo_translate.py View 1 chunk +0 lines, -145 lines 0 comments Download
A + mojo/public/tools/bindings/generators/cpp_templates/enum_declaration.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/bindings/generators/cpp_templates/interface_declaration.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/bindings/generators/cpp_templates/interface_macros.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/bindings/generators/cpp_templates/interface_proxy_declaration.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/bindings/generators/cpp_templates/interface_stub_declaration.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/bindings/generators/cpp_templates/module-internal.h.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/bindings/generators/cpp_templates/params_definition.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/bindings/generators/cpp_templates/struct_builder_definition.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/bindings/generators/cpp_templates/struct_declaration.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/bindings/generators/cpp_templates/struct_destructor.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/bindings/generators/js_templates/enum_definition.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/bindings/generators/js_templates/module.js.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/bindings/generators/js_templates/struct_definition.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/bindings/generators/mojom_cpp_generator.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/bindings/generators/mojom_js_generator.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/bindings/generators/run_cpp_generator.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A mojo/public/tools/bindings/mojom_bindings_generator.gypi View 1 chunk +80 lines, -0 lines 0 comments Download
A + mojo/public/tools/bindings/mojom_bindings_generator.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/bindings/pylib/generate/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/bindings/pylib/generate/mojom.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/bindings/pylib/generate/mojom_data.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/bindings/pylib/generate/mojom_data_tests.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/bindings/pylib/generate/mojom_generator.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/bindings/pylib/generate/mojom_pack.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/bindings/pylib/generate/mojom_pack_tests.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/bindings/pylib/generate/mojom_test.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/bindings/pylib/generate/mojom_tests.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/bindings/pylib/generate/run_mojom_tests.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/bindings/pylib/generate/template_expander.py View 1 chunk +3 lines, -8 lines 0 comments Download
A + mojo/public/tools/bindings/pylib/parse/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/bindings/pylib/parse/mojo_lexer.py View 1 chunk +2 lines, -1 line 0 comments Download
A + mojo/public/tools/bindings/pylib/parse/mojo_lexer_unittest.py View 1 chunk +2 lines, -1 line 0 comments Download
A + mojo/public/tools/bindings/pylib/parse/mojo_parser.py View 1 1 chunk +2 lines, -1 line 0 comments Download
A + mojo/public/tools/bindings/pylib/parse/mojo_parser_unittest.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/tools/bindings/pylib/parse/mojo_translate.py View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
viettrungluu
6 years, 8 months ago (2014-04-04 16:34:20 UTC) #1
sky
Gah! You're doing this just to make my life hard, aren't you:) LGTM
6 years, 8 months ago (2014-04-04 17:27:50 UTC) #2
sky
I say that since I have two patches out that touch some of these files: ...
6 years, 8 months ago (2014-04-04 17:28:49 UTC) #3
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 8 months ago (2014-04-04 18:05:00 UTC) #4
viettrungluu
On 2014/04/04 17:28:49, sky wrote: > I say that since I have two patches out ...
6 years, 8 months ago (2014-04-04 18:05:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/226263002/1
6 years, 8 months ago (2014-04-04 18:06:12 UTC) #6
viettrungluu
6 years, 8 months ago (2014-04-04 21:11:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r261874 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698