Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 226213002: Removes use_mojo (Closed)

Created:
6 years, 8 months ago by sky
Modified:
6 years, 8 months ago
Reviewers:
Tom Sepez, jam, viettrungluu
CC:
chromium-reviews, creis+watch_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Removes use_mojo Now that we've sorted out the build issues on all platforms it can be removed. BUG=353602 TEST=none R=jam@chromium.org TBR=tsepez@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262032

Patch Set 1 #

Patch Set 2 : merge 2 trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -200 lines) Patch
M build/common.gypi View 1 5 chunks +0 lines, -14 lines 0 comments Download
M content/app/content_main_runner.cc View 4 chunks +3 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 5 chunks +2 lines, -12 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 6 chunks +1 line, -10 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 2 chunks +1 line, -4 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 2 chunks +16 lines, -18 lines 0 comments Download
M content/browser/webui/web_ui_data_source_impl.cc View 3 chunks +1 line, -6 lines 0 comments Download
M content/common/content_message_generator.h View 2 chunks +1 line, -4 lines 0 comments Download
M content/content.gyp View 1 chunk +1 line, -5 lines 0 comments Download
M content/content_app.gypi View 1 chunk +1 line, -5 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +3 lines, -12 lines 0 comments Download
M content/content_common.gypi View 2 chunks +3 lines, -12 lines 0 comments Download
M content/content_renderer.gypi View 2 chunks +3 lines, -18 lines 0 comments Download
M content/content_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 1 4 chunks +7 lines, -24 lines 0 comments Download
M content/public/browser/render_view_host.h View 3 chunks +4 lines, -9 lines 0 comments Download
M content/public/browser/web_ui_data_source.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 3 chunks +1 line, -6 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 3 chunks +1 line, -6 lines 0 comments Download
M content/test/content_test_launcher.cc View 2 chunks +2 lines, -9 lines 0 comments Download
M mojo/tools/mojob.sh View 3 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sky
tsepez: content/common/content_message_generator.h vtl: mojo/tools/mojob.sh jam: the rest
6 years, 8 months ago (2014-04-04 15:55:04 UTC) #1
viettrungluu
mojob lgtm
6 years, 8 months ago (2014-04-04 16:15:52 UTC) #2
jam
lgtm
6 years, 8 months ago (2014-04-04 17:07:31 UTC) #3
sky
tsepez: I'm TBRing you as this is just removing an ifdef.
6 years, 8 months ago (2014-04-04 22:52:16 UTC) #4
sky
The CQ bit was checked by sky@chromium.org
6 years, 8 months ago (2014-04-05 17:24:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/226213002/20001
6 years, 8 months ago (2014-04-05 17:24:25 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-05 20:14:21 UTC) #7
Message was sent while issue was closed. 
Change committed as 262032

Powered by Google App Engine
This is Rietveld 408576698