chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcherTest.java - Issue 2262583002: Do not request upgrade if Web Manifest is no longer WebAPK-capable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcherTest.java

Issue 2262583002: Do not request upgrade if Web Manifest is no longer WebAPK-capable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcher.java ('k') | chrome/android/junit/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java » ('j') | chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcherTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcherTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcherTest.java

index ee27c9479508014240a05937bceafe245f50ebee..dc1cce54e0a1d1a82f089440e88dd6015862fe0d 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcherTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcherTest.java

@@ -46,9 +46,10 @@ public class ManifestUpgradeDetectorFetcherTest extends ChromeTabbedActivityTest

private String mName;

@Override

- public void onGotManifestData(String startUrl, String scopeUrl, String name,

- String shortName, String iconUrl, long iconMurmur2Hash, Bitmap iconBitmap,

- int displayMode, int orientation, long themeColor, long backgroundColor) {

+ public void onGotManifestData(boolean isInstallable, String startUrl, String scopeUrl,

+ String name, String shortName, String iconUrl, long iconMurmur2Hash,

+ Bitmap iconBitmap, int displayMode, int orientation, long themeColor,

+ long backgroundColor) {

assertNull(mName);

mName = name;

notifyCalled();