Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcher.java

Issue 2262583002: Do not request upgrade if Web Manifest is no longer WebAPK-capable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcher.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcher.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcher.java
index cfbc09e7b07214af9b74833f8354abab10ce129d..0df1ab5fecd84cb486a95eaa0d77cc6dfc6cc113 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcher.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcher.java
@@ -21,9 +21,10 @@ public class ManifestUpgradeDetectorFetcher extends EmptyTabObserver {
* Called once the Web Manifest has been downloaded.
*/
public interface Callback {
- public void onGotManifestData(String startUrl, String scopeUrl, String name,
- String shortName, String iconUrl, long iconMurmur2Hash, Bitmap iconBitmap,
- int displayMode, int orientation, long themeColor, long backgroundColor);
+ public void onGotManifestData(boolean isInstallable, String startUrl, String scopeUrl,
+ String name, String shortName, String iconUrl, long iconMurmur2Hash,
+ Bitmap iconBitmap, int displayMode, int orientation, long themeColor,
+ long backgroundColor);
}
/**
@@ -83,11 +84,11 @@ public class ManifestUpgradeDetectorFetcher extends EmptyTabObserver {
* Called when the updated Web Manifest has been fetched.
*/
@CalledByNative
- private void onDataAvailable(String startUrl, String scopeUrl, String name, String shortName,
- String iconUrl, long iconMurmur2Hash, Bitmap iconBitmap, int displayMode,
- int orientation, long themeColor, long backgroundColor) {
- mCallback.onGotManifestData(startUrl, scopeUrl, name, shortName, iconUrl, iconMurmur2Hash,
- iconBitmap, displayMode, orientation, themeColor, backgroundColor);
+ private void onDataAvailable(boolean isInstallable, String startUrl, String scopeUrl,
+ String name, String shortName, String iconUrl, long iconMurmur2Hash, Bitmap iconBitmap,
+ int displayMode, int orientation, long themeColor, long backgroundColor) {
+ mCallback.onGotManifestData(isInstallable, startUrl, scopeUrl, name, shortName, iconUrl,
+ iconMurmur2Hash, iconBitmap, displayMode, orientation, themeColor, backgroundColor);
}
private native long nativeInitialize(String scope, String webManifestUrl);

Powered by Google App Engine
This is Rietveld 408576698