chrome/browser/ui/views/frame/opaque_browser_frame_view.h - Issue 2262563002: Refactor DoesIntersectRect into BrowserNonClientFrameView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/opaque_browser_frame_view.h

Issue 2262563002: Refactor DoesIntersectRect into BrowserNonClientFrameView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc ('k') | chrome/browser/ui/views/frame/opaque_browser_frame_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/opaque_browser_frame_view.h

diff --git a/chrome/browser/ui/views/frame/opaque_browser_frame_view.h b/chrome/browser/ui/views/frame/opaque_browser_frame_view.h

index a78ec1bc54050777bb10451855d1434c6ed2f5a5..937d9d1ea7626473aa7a3dbf5210bafc04b803a0 100644

--- a/chrome/browser/ui/views/frame/opaque_browser_frame_view.h

+++ b/chrome/browser/ui/views/frame/opaque_browser_frame_view.h

@@ -105,10 +105,6 @@ class OpaqueBrowserFrameView : public BrowserNonClientFrameView,

void UpdateProfileIcons() override;

private:

- // views::NonClientFrameView:

- bool DoesIntersectRect(const views::View* target,

- const gfx::Rect& rect) const override;

// Creates, adds and returns a new image button with |this| as its listener.

// Memory is owned by the caller.

views::ImageButton* InitWindowCaptionButton(int normal_image_id,