Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6221)

Unified Diff: chrome/browser/ui/views/frame/opaque_browser_frame_view.cc

Issue 2262563002: Refactor DoesIntersectRect into BrowserNonClientFrameView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/frame/opaque_browser_frame_view.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
diff --git a/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc b/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
index a948beea100100e29ae838aff289144ea89f57ee..7b1cd99e2fcb958cb246b4bfb9a8d68db33439f8 100644
--- a/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
+++ b/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
@@ -455,50 +455,6 @@ void OpaqueBrowserFrameView::UpdateProfileIcons() {
///////////////////////////////////////////////////////////////////////////////
// OpaqueBrowserFrameView, private:
-// views::NonClientFrameView:
-bool OpaqueBrowserFrameView::DoesIntersectRect(const views::View* target,
- const gfx::Rect& rect) const {
- CHECK_EQ(target, this);
- if (!views::ViewTargeterDelegate::DoesIntersectRect(this, rect)) {
- // |rect| is outside OpaqueBrowserFrameView's bounds.
- return false;
- }
-
- // If the rect is outside the bounds of the client area, claim it.
- gfx::RectF rect_in_client_view_coords_f(rect);
- View::ConvertRectToTarget(this, frame()->client_view(),
- &rect_in_client_view_coords_f);
- gfx::Rect rect_in_client_view_coords = gfx::ToEnclosingRect(
- rect_in_client_view_coords_f);
- if (!frame()->client_view()->HitTestRect(rect_in_client_view_coords))
- return true;
-
- // Otherwise, claim |rect| only if it is above the bottom of the tabstrip in
- // a non-tab portion.
- TabStrip* tabstrip = browser_view()->tabstrip();
- if (!tabstrip || !browser_view()->IsTabStripVisible())
- return false;
-
- gfx::RectF rect_in_tabstrip_coords_f(rect);
- View::ConvertRectToTarget(this, tabstrip, &rect_in_tabstrip_coords_f);
- gfx::Rect rect_in_tabstrip_coords = gfx::ToEnclosingRect(
- rect_in_tabstrip_coords_f);
- if (rect_in_tabstrip_coords.bottom() > tabstrip->GetLocalBounds().bottom()) {
- // |rect| is below the tabstrip.
- return false;
- }
-
- if (tabstrip->HitTestRect(rect_in_tabstrip_coords)) {
- // Claim |rect| if it is in a non-tab portion of the tabstrip.
- return tabstrip->IsRectInWindowCaption(rect_in_tabstrip_coords);
- }
-
- // We claim |rect| because it is above the bottom of the tabstrip, but
- // not in the tabstrip itself. In particular, the avatar label/button is left
- // of the tabstrip and the window controls are right of the tabstrip.
- return true;
-}
-
views::ImageButton* OpaqueBrowserFrameView::InitWindowCaptionButton(
int normal_image_id,
int hot_image_id,
« no previous file with comments | « chrome/browser/ui/views/frame/opaque_browser_frame_view.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698