Use a vector of smart pointers for callback return type.

components/offline_pages/background/request_coordinator.h

Index: components/offline_pages/background/request_coordinator.h
diff --git a/components/offline_pages/background/request_coordinator.h b/components/offline_pages/background/request_coordinator.h
index 623015d4799a03aa03e76216a60ddace1c4ade19..10e00059547dd50479bd04300bc1e8e0622e689a 100644
--- a/components/offline_pages/background/request_coordinator.h
+++ b/components/offline_pages/background/request_coordinator.h
@@ -92,7 +92,7 @@ class RequestCoordinator : public KeyedService,
   // Callback that receives the response for GetAllRequests.  Client must
   // copy the result right away, it goes out of scope at the end of the

[Dmitry Titov, 2016/08/26 23:39:20]

This comment needs updating.

[Pete Williamson, 2016/08/27 00:11:59]

Done.

   // callback.
-  typedef base::Callback<void(const std::vector<SavePageRequest>&)>
+  typedef base::Callback<void(std::vector<std::unique_ptr<SavePageRequest>>)>
       GetRequestsCallback;
 
   // Get all save page request items in the callback.
@@ -159,9 +159,10 @@ class RequestCoordinator : public KeyedService,
  private:
   // Receives the results of a get from the request queue, and turns that into
   // SavePageRequest objects for the caller of GetQueuedRequests.
-  void GetQueuedRequestsCallback(const GetRequestsCallback& callback,
-                                 RequestQueue::GetRequestsResult result,
-                                 const std::vector<SavePageRequest>& requests);
+  void GetQueuedRequestsCallback(
+      const GetRequestsCallback& callback,
+      RequestQueue::GetRequestsResult result,
+      std::vector<std::unique_ptr<SavePageRequest>> requests);
 
   // Receives the result of add requests to the request queue.
   void AddRequestResultCallback(RequestQueue::AddRequestResult result,
@@ -173,16 +174,16 @@ class RequestCoordinator : public KeyedService,
 
   void UpdateMultipleRequestsCallback(
       const RequestQueue::UpdateMultipleRequestResults& result,
-      const std::vector<SavePageRequest>& requests);
+      std::vector<std::unique_ptr<SavePageRequest>> requests);
 
   void HandleRemovedRequestsAndCallback(
       const RemoveRequestsCallback& callback,
       const RequestQueue::UpdateMultipleRequestResults& results,
-      const std::vector<SavePageRequest>& requests);
+      std::vector<std::unique_ptr<SavePageRequest>> requests);
 
   void HandleRemovedRequests(
       const RequestQueue::UpdateMultipleRequestResults& results,
-      const std::vector<SavePageRequest>& requests);
+      std::vector<std::unique_ptr<SavePageRequest>> requests);
 
   // Callback from the request picker when it has chosen our next request.
   void RequestPicked(const SavePageRequest& request);