chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc - Issue 2262423002: Use a vector of smart pointers for callback return type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc

Issue 2262423002: Use a vector of smart pointers for callback return type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Logical merge fixes Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.h ('k') | components/offline_pages/background/request_coordinator.h » ('j') | components/offline_pages/background/request_coordinator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc

diff --git a/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc b/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc

index 9a8adbb9d7b39ef011ccf34d79cba9c9d8e6b35f..210de8a5ea04d5f496dfc285cb0c4b695f70b34e 100644

--- a/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc

+++ b/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc

@@ -118,7 +118,7 @@ void OfflineInternalsUIMessageHandler::HandleStoredPagesCallback(

void OfflineInternalsUIMessageHandler::HandleRequestQueueCallback(

std::string callback_id,

offline_pages::RequestQueue::GetRequestsResult result,

- const std::vector<offline_pages::SavePageRequest>& requests) {

+ std::vector<std::unique_ptr<offline_pages::SavePageRequest>> requests) {

base::ListValue save_page_requests;

if (result == offline_pages::RequestQueue::GetRequestsResult::SUCCESS) {

for (const auto& request : requests) {