Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: components/offline_pages/background/request_coordinator.cc

Issue 2262423002: Use a vector of smart pointers for callback return type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Logical merge fixes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_coordinator.cc
diff --git a/components/offline_pages/background/request_coordinator.cc b/components/offline_pages/background/request_coordinator.cc
index 4f0bef7d3b876fac3701cf0f919f765d586f06ea..8c9fa07be9a65c29ea12fcbc6b6423a37d98dabc 100644
--- a/components/offline_pages/background/request_coordinator.cc
+++ b/components/offline_pages/background/request_coordinator.cc
@@ -107,8 +107,8 @@ void RequestCoordinator::GetAllRequests(const GetRequestsCallback& callback) {
void RequestCoordinator::GetQueuedRequestsCallback(
const GetRequestsCallback& callback,
RequestQueue::GetRequestsResult result,
- const std::vector<SavePageRequest>& requests) {
- callback.Run(requests);
+ std::vector<std::unique_ptr<SavePageRequest>> requests) {
+ callback.Run(std::move(requests));
}
void RequestCoordinator::StopPrerendering() {
@@ -207,24 +207,26 @@ void RequestCoordinator::UpdateRequestCallback(
// Called in response to updating multiple requests in the request queue.
void RequestCoordinator::UpdateMultipleRequestsCallback(
const RequestQueue::UpdateMultipleRequestResults& results,
- const std::vector<SavePageRequest>& requests) {
- for (SavePageRequest request : requests)
- NotifyChanged(request);
+ std::vector<std::unique_ptr<SavePageRequest>> requests) {
+ std::vector<std::unique_ptr<SavePageRequest>>::iterator request;
Dmitry Titov 2016/08/26 23:39:20 would something like this work: for (const auto& r
Pete Williamson 2016/08/27 00:11:59 Done.
+ for (request = requests.begin(); request != requests.end(); ++request)
+ NotifyChanged(*(request->get()));
}
void RequestCoordinator::HandleRemovedRequestsAndCallback(
const RemoveRequestsCallback& callback,
const RequestQueue::UpdateMultipleRequestResults& results,
- const std::vector<SavePageRequest>& requests) {
+ std::vector<std::unique_ptr<SavePageRequest>> requests) {
callback.Run(results);
- HandleRemovedRequests(results, requests);
+ HandleRemovedRequests(results, std::move(requests));
}
void RequestCoordinator::HandleRemovedRequests(
const RequestQueue::UpdateMultipleRequestResults& results,
- const std::vector<SavePageRequest>& requests) {
- for (SavePageRequest request : requests)
- NotifyCompleted(request, SavePageStatus::REMOVED);
+ std::vector<std::unique_ptr<SavePageRequest>> requests) {
+ std::vector<std::unique_ptr<SavePageRequest>>::iterator request;
+ for (request = requests.begin(); request != requests.end(); ++request)
+ NotifyCompleted(*(request->get()), SavePageStatus::REMOVED);
}
void RequestCoordinator::StopProcessing() {

Powered by Google App Engine
This is Rietveld 408576698