chrome/browser/android/offline_pages/offline_page_bridge.cc - Issue 2262423002: Use a vector of smart pointers for callback return type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/offline_page_bridge.cc

Issue 2262423002: Use a vector of smart pointers for callback return type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Logical merge fixes Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.h » ('j') | components/offline_pages/background/request_coordinator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/offline_page_bridge.cc

diff --git a/chrome/browser/android/offline_pages/offline_page_bridge.cc b/chrome/browser/android/offline_pages/offline_page_bridge.cc

index 95f53fdb8b8c9a9ee8943352cfc7ab80448c48e9..bbac60179ad78ed38bd44b57243032c88fd07613 100644

--- a/chrome/browser/android/offline_pages/offline_page_bridge.cc

+++ b/chrome/browser/android/offline_pages/offline_page_bridge.cc

@@ -163,8 +163,9 @@ ScopedJavaLocalRef<jobjectArray> CreateJavaSavePageRequests(

return ScopedJavaLocalRef<jobjectArray>(env, joa);

}

-void OnGetAllRequestsDone(const ScopedJavaGlobalRef<jobject>& j_callback_obj,

- const std::vector<SavePageRequest>& all_requests) {

+void OnGetAllRequestsDone(

+ const ScopedJavaGlobalRef<jobject>& j_callback_obj,

+ std::vector<std::unique_ptr<SavePageRequest>> all_requests) {

JNIEnv* env = base::android::AttachCurrentThread();

ScopedJavaLocalRef<jobjectArray> j_result_obj =