|
|
Chromium Code Reviews|
Created:
4 years, 4 months ago by Daniele Castagna Modified:
4 years, 2 months ago CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@yuv-test-image Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptiongl: Add YV12 to bind image unittests.
It is now possible to allocate and map a YV12 buffer in chromium
via minigbm. (https://chromium-review.googlesource.com/c/373048/,
crrev.com/2279553002 and crrev.com/2272153002)
This CL adds YV12 to the list of imagebind tests.
TEST=ozone_gl_unittests --gtest_also_run_disabled_tests on samus
BUG=618516
Committed: https://crrev.com/f32c40b79ebcdd5aab1ed0ccd9d7f0a51b3db0d7
Cr-Commit-Position: refs/heads/master@{#421901}
Patch Set 1 #Patch Set 2 : Rebase on Master. Use a different color for YVU tests. #
Messages
Total messages: 26 (17 generated)
Description was changed from ========== gl: Add YV12 to bind image unittests. Thanks to https://chromium-review.googlesource.com/c/373048/ we should be able to allocate YV12 buffer directly via minigbm on intel. This CL adds YV12 to the list of imagebind tests. Once this tests pass, we can get rid of the image drm unittests that was originally introduced to test YV12 on intel. BUG=618516 ========== to ========== gl: Add YV12 to bind image unittests. Thanks to https://chromium-review.googlesource.com/c/373048/ we should be able to allocate YV12 buffer directly via minigbm on intel. This CL adds YV12 to the list of imagebind tests. Once this test passes, we can get rid of the image drm unittest that was originally introduced to test YV12 on intel. BUG=618516 ==========
dcastagna@chromium.org changed reviewers: + gurchetansingh@chromium.org, reveman@chromium.org
lgtm
The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== gl: Add YV12 to bind image unittests. Thanks to https://chromium-review.googlesource.com/c/373048/ we should be able to allocate YV12 buffer directly via minigbm on intel. This CL adds YV12 to the list of imagebind tests. Once this test passes, we can get rid of the image drm unittest that was originally introduced to test YV12 on intel. BUG=618516 ========== to ========== gl: Add YV12 to bind image unittests. It is now possible to allocate and map a YV12 buffer in chromium using minigbm. (https://chromium-review.googlesource.com/c/373048/, https://codereview.chromium.org/2279553002 and https://codereview.chromium.org/2272153002) This CL adds YV12 to the list of imagebind tests. BUG=618516 ==========
Description was changed from ========== gl: Add YV12 to bind image unittests. It is now possible to allocate and map a YV12 buffer in chromium using minigbm. (https://chromium-review.googlesource.com/c/373048/, https://codereview.chromium.org/2279553002 and https://codereview.chromium.org/2272153002) This CL adds YV12 to the list of imagebind tests. BUG=618516 ========== to ========== gl: Add YV12 to bind image unittests. It is now possible to allocate and map a YV12 buffer in chromium using minigbm. (https://chromium-review.googlesource.com/c/373048/, https://codereview.chromium.org/2279553002 and https://codereview.chromium.org/2272153002) This CL adds YV12 to the list of imagebind tests. BUG=618516 ==========
Description was changed from ========== gl: Add YV12 to bind image unittests. It is now possible to allocate and map a YV12 buffer in chromium using minigbm. (https://chromium-review.googlesource.com/c/373048/, https://codereview.chromium.org/2279553002 and https://codereview.chromium.org/2272153002) This CL adds YV12 to the list of imagebind tests. BUG=618516 ========== to ========== gl: Add YV12 to bind image unittests. It is now possible to allocate and map a YV12 buffer in chromium using minigbm. (https://chromium-review.googlesource.com/c/373048/, https://codereview.chromium.org/2279553002 and https://codereview.chromium.org/2272153002) This CL adds YV12 to the list of imagebind tests. TEST=ozone_gl_unittests --gtest_also_run_disabled_tests on samus BUG=618516 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== gl: Add YV12 to bind image unittests. It is now possible to allocate and map a YV12 buffer in chromium using minigbm. (https://chromium-review.googlesource.com/c/373048/, https://codereview.chromium.org/2279553002 and https://codereview.chromium.org/2272153002) This CL adds YV12 to the list of imagebind tests. TEST=ozone_gl_unittests --gtest_also_run_disabled_tests on samus BUG=618516 ========== to ========== gl: Add YV12 to bind image unittests. It is now possible to allocate and map a YV12 buffer in chromium using minigbm. (https://chromium-review.googlesource.com/c/373048/, crrev.com/2279553002 and crrev.com/2272153002) This CL adds YV12 to the list of imagebind tests. TEST=ozone_gl_unittests --gtest_also_run_disabled_tests on samus BUG=618516 ==========
Description was changed from ========== gl: Add YV12 to bind image unittests. It is now possible to allocate and map a YV12 buffer in chromium using minigbm. (https://chromium-review.googlesource.com/c/373048/, crrev.com/2279553002 and crrev.com/2272153002) This CL adds YV12 to the list of imagebind tests. TEST=ozone_gl_unittests --gtest_also_run_disabled_tests on samus BUG=618516 ========== to ========== gl: Add YV12 to bind image unittests. It is now possible to allocate and map a YV12 buffer in chromium via minigbm. (https://chromium-review.googlesource.com/c/373048/, crrev.com/2279553002 and crrev.com/2272153002) This CL adds YV12 to the list of imagebind tests. TEST=ozone_gl_unittests --gtest_also_run_disabled_tests on samus BUG=618516 ==========
The CQ bit was checked by dcastagna@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org Link to the patchset: https://codereview.chromium.org/2262353002/#ps20001 (title: "Rebase on Master. Use a different color for YVU tests.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
dcastagna@chromium.org changed reviewers: + spang@chromium.org
+spang for ownership. I had ownership LGTM already, but then files move around, and now I need it again. :/
The CQ bit was checked by spang@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== gl: Add YV12 to bind image unittests. It is now possible to allocate and map a YV12 buffer in chromium via minigbm. (https://chromium-review.googlesource.com/c/373048/, crrev.com/2279553002 and crrev.com/2272153002) This CL adds YV12 to the list of imagebind tests. TEST=ozone_gl_unittests --gtest_also_run_disabled_tests on samus BUG=618516 ========== to ========== gl: Add YV12 to bind image unittests. It is now possible to allocate and map a YV12 buffer in chromium via minigbm. (https://chromium-review.googlesource.com/c/373048/, crrev.com/2279553002 and crrev.com/2272153002) This CL adds YV12 to the list of imagebind tests. TEST=ozone_gl_unittests --gtest_also_run_disabled_tests on samus BUG=618516 Committed: https://crrev.com/f32c40b79ebcdd5aab1ed0ccd9d7f0a51b3db0d7 Cr-Commit-Position: refs/heads/master@{#421901} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/f32c40b79ebcdd5aab1ed0ccd9d7f0a51b3db0d7 Cr-Commit-Position: refs/heads/master@{#421901} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
