Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2262353002: gl: Add YV12 to bind image unittests. (Closed)

Created:
4 years, 4 months ago by Daniele Castagna
Modified:
4 years, 2 months ago
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@yuv-test-image
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gl: Add YV12 to bind image unittests. It is now possible to allocate and map a YV12 buffer in chromium via minigbm. (https://chromium-review.googlesource.com/c/373048/, crrev.com/2279553002 and crrev.com/2272153002) This CL adds YV12 to the list of imagebind tests. TEST=ozone_gl_unittests --gtest_also_run_disabled_tests on samus BUG=618516 Committed: https://crrev.com/f32c40b79ebcdd5aab1ed0ccd9d7f0a51b3db0d7 Cr-Commit-Position: refs/heads/master@{#421901}

Patch Set 1 #

Patch Set 2 : Rebase on Master. Use a different color for YVU tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M ui/ozone/gl/gl_image_ozone_native_pixmap.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M ui/ozone/gl/gl_image_ozone_native_pixmap_unittest.cc View 1 3 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (17 generated)
Daniele Castagna
4 years, 4 months ago (2016-08-22 20:41:56 UTC) #3
reveman
lgtm
4 years, 4 months ago (2016-08-22 21:40:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2262353002/20001
4 years, 2 months ago (2016-09-28 19:00:13 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/268802)
4 years, 2 months ago (2016-09-28 19:06:46 UTC) #18
Daniele Castagna
+spang for ownership. I had ownership LGTM already, but then files move around, and now ...
4 years, 2 months ago (2016-09-28 19:07:36 UTC) #20
spang
lgtm
4 years, 2 months ago (2016-09-29 19:14:04 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2262353002/20001
4 years, 2 months ago (2016-09-29 19:14:25 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-29 19:35:55 UTC) #24
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 19:38:19 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f32c40b79ebcdd5aab1ed0ccd9d7f0a51b3db0d7
Cr-Commit-Position: refs/heads/master@{#421901}

Powered by Google App Engine
This is Rietveld 408576698