Add ClientNativePixmap multi-planar support.

Add ClientNativePixmap multi-planar support.

ClientNativePixmap, that lets clients map pixmaps in user space,
always assumed a pixmap contained only one plane.

This CL adds support for multiple-planes.

BUG=618516
TBR=posciak
TEST=gl_unittests on samus.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/cdb357b81306f5e8170027d13d931b8e26140405
Committed: https://crrev.com/3085817730f8c6eacc1b6f02e78a712aefcaaacd
Cr-Original-Commit-Position: refs/heads/master@{#420251}
Cr-Commit-Position: refs/heads/master@{#421543}

[Daniele Castagna, 2016-08-24 20:43:18]

Description was changed from

==========
Add ClientNativePixmap multi-planar support.

ClientNativePixmap, that lets clients map pixmaps in user space,
always assumed a pixmap contained only one plane.

This CL adds support for multiple-planes.

crrev.com/2262353002, that tests a pixmap lifetime with a YVU format is
still not passing. It's currently failing on eglCreateImageKHR with
EGL_BAD_ALLOC.

BUG=618516
TEST=gl_unittests on samus.
==========

to

==========
Add ClientNativePixmap multi-planar support.

ClientNativePixmap, that lets clients map pixmaps in user space,
always assumed a pixmap contained only one plane.

This CL adds support for multiple-planes.

crrev.com/2262353002, that tests a pixmap lifetime with a YVU format is
still not passing. It's currently failing on eglCreateImageKHR with
EGL_BAD_ALLOC.

BUG=618516
TEST=gl_unittests on samus.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Daniele Castagna, 2016-08-24 20:43:21]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 20:44:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reveman, 2016-08-24 20:54:06]

reveman@chromium.org changed reviewers:
+ reveman@chromium.org

[reveman, 2016-08-24 20:54:07]

lgtm

[Daniele Castagna, 2016-08-24 20:59:27]

ccing wuchengli@ and gurchetansingh@.

gurchetansingh@, with this patch plus your yv12 minigbm change I can run the
YV12 test in crrev.com/2262353002. Unfortunately it fails in eglCreateImageKHR
with EGL_BAD_ALLOC.

Do you have any idea what it could be?

[commit-bot: I haz the power, 2016-08-24 21:04:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 21:04:10]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[Daniele Castagna, 2016-08-30 00:36:35]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 01:24:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniele Castagna, 2016-08-30 01:34:11]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 02:45:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 03:53:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 03:53:44]

Dry run: This issue passed the CQ dry run.

[Daniele Castagna, 2016-08-30 17:58:29]

On 2016/08/24 at 20:59:27, Daniele Castagna wrote:
> ccing wuchengli@ and gurchetansingh@.
> 
> gurchetansingh@, with this patch plus your yv12 minigbm change I can run the
YV12 test in crrev.com/2262353002. Unfortunately it fails in eglCreateImageKHR
with EGL_BAD_ALLOC.
> 
> Do you have any idea what it could be?

gurchetansingh@, seems like minigbm gives us different fds for each plane, but
Intel mesa wants the same fd for all the planes: crbug.com/642410

[Daniele Castagna, 2016-08-30 18:01:20]

On 2016/08/30 at 17:58:29, Daniele Castagna wrote:
> On 2016/08/24 at 20:59:27, Daniele Castagna wrote:
> > ccing wuchengli@ and gurchetansingh@.
> > 
> > gurchetansingh@, with this patch plus your yv12 minigbm change I can run the
YV12 test in crrev.com/2262353002. Unfortunately it fails in eglCreateImageKHR
with EGL_BAD_ALLOC.
> > 
> > Do you have any idea what it could be?
> 
> gurchetansingh@, seems like minigbm gives us different fds for each plane, but
Intel mesa wants the same fd for all the planes: crbug.com/642410

The patch has been updated to use only the fd from the first plane and ignore
the other ones, and now it seems to work.

[Daniele Castagna, 2016-09-14 16:09:40]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 16:10:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 16:23:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 16:23:52]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Daniele Castagna, 2016-09-14 19:14:55]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 19:15:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniele Castagna, 2016-09-14 19:15:59]

Description was changed from

==========
Add ClientNativePixmap multi-planar support.

ClientNativePixmap, that lets clients map pixmaps in user space,
always assumed a pixmap contained only one plane.

This CL adds support for multiple-planes.

crrev.com/2262353002, that tests a pixmap lifetime with a YVU format is
still not passing. It's currently failing on eglCreateImageKHR with
EGL_BAD_ALLOC.

BUG=618516
TEST=gl_unittests on samus.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add ClientNativePixmap multi-planar support.

ClientNativePixmap, that lets clients map pixmaps in user space,
always assumed a pixmap contained only one plane.

This CL adds support for multiple-planes.

BUG=618516
TEST=gl_unittests on samus.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-09-14 19:41:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 19:41:45]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Daniele Castagna, 2016-09-14 20:32:11]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[Daniele Castagna, 2016-09-14 20:32:19]

Patchset #6 (id:100001) has been deleted

[commit-bot: I haz the power, 2016-09-14 20:33:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniele Castagna, 2016-09-14 20:44:33]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 20:45:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniele Castagna, 2016-09-14 21:18:47]

dcastagna@chromium.org changed reviewers:
+ dnicoara@chromium.org

[dnicoara, 2016-09-14 21:47:40]

Looks good, just one thing that I noticed.

https://codereview.chromium.org/2272153002/diff/140001/ui/ozone/platform/drm/...
File ui/ozone/platform/drm/client_native_pixmap_factory_gbm.cc (right):

https://codereview.chromium.org/2272153002/diff/140001/ui/ozone/platform/drm/...
ui/ozone/platform/drm/client_native_pixmap_factory_gbm.cc:86: #if
defined(OS_CHROMEOS)
On the non-CrOS case this would be leaking the FDs.

[commit-bot: I haz the power, 2016-09-15 01:23:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 01:23:09]

Dry run: This issue passed the CQ dry run.

[Daniele Castagna, 2016-09-19 18:25:14]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 18:25:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniele Castagna, 2016-09-19 18:26:38]

dcastagna@chromium.org changed reviewers:
+ spang@chromium.org

[Daniele Castagna, 2016-09-19 18:26:40]

+spang for ozone since dnicoara is on vacation.

https://codereview.chromium.org/2272153002/diff/140001/ui/ozone/platform/drm/...
File ui/ozone/platform/drm/client_native_pixmap_factory_gbm.cc (right):

https://codereview.chromium.org/2272153002/diff/140001/ui/ozone/platform/drm/...
ui/ozone/platform/drm/client_native_pixmap_factory_gbm.cc:86: #if
defined(OS_CHROMEOS)
On 2016/09/14 at 21:47:40, dnicoara wrote:
> On the non-CrOS case this would be leaking the FDs.

True, but the non-CrOS case should never be reached, right?

https://codereview.chromium.org/2272153002/diff/140001/ui/ozone/platform/drm/...
File ui/ozone/platform/drm/gpu/gbm_buffer.cc (right):

https://codereview.chromium.org/2272153002/diff/140001/ui/ozone/platform/drm/...
ui/ozone/platform/drm/gpu/gbm_buffer.cc:132: base::ScopedFD
fd(gbm_bo_get_plane_fd(bo, i));
Here on the other hand I'm afraid we were leaking fds. Fixed this.

[Daniele Castagna, 2016-09-19 18:52:59]

dcastagna@chromium.org changed reviewers:
+ ccameron@chromium.org, posciak@chromium.org

[Daniele Castagna, 2016-09-19 18:53:00]

+ccameron for ui/gfx/native_pixmap_handle.*
+posciak for chrome/gpu/* and media/gpu/*

[ccameron, 2016-09-19 18:56:27]

ui/ stamp lgtm

[commit-bot: I haz the power, 2016-09-19 20:54:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 20:54:45]

Dry run: This issue passed the CQ dry run.

[spang, 2016-09-21 03:41:25]

lgtm

[Daniele Castagna, 2016-09-22 02:00:11]

Description was changed from

==========
Add ClientNativePixmap multi-planar support.

ClientNativePixmap, that lets clients map pixmaps in user space,
always assumed a pixmap contained only one plane.

This CL adds support for multiple-planes.

BUG=618516
TEST=gl_unittests on samus.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add ClientNativePixmap multi-planar support.

ClientNativePixmap, that lets clients map pixmaps in user space,
always assumed a pixmap contained only one plane.

This CL adds support for multiple-planes.

BUG=618516
TBR=posciack
TEST=gl_unittests on samus.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Daniele Castagna, 2016-09-22 02:00:36]

On 2016/09/21 at 03:41:25, spang wrote:
> lgtm

TBRring posciak that is out till next week.

[Daniele Castagna, 2016-09-22 02:00:54]

Description was changed from

==========
Add ClientNativePixmap multi-planar support.

ClientNativePixmap, that lets clients map pixmaps in user space,
always assumed a pixmap contained only one plane.

This CL adds support for multiple-planes.

BUG=618516
TBR=posciack
TEST=gl_unittests on samus.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add ClientNativePixmap multi-planar support.

ClientNativePixmap, that lets clients map pixmaps in user space,
always assumed a pixmap contained only one plane.

This CL adds support for multiple-planes.

BUG=618516
TBR=posciak
TEST=gl_unittests on samus.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Daniele Castagna, 2016-09-22 02:00:58]

The CQ bit was checked by dcastagna@chromium.org

[Daniele Castagna, 2016-09-22 02:00:59]

The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2272153002/#ps160001
(title: "Fix fds leak.")

[commit-bot: I haz the power, 2016-09-22 02:01:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 03:24:53]

Committed patchset #8 (id:160001)

[commit-bot: I haz the power, 2016-09-22 03:29:16]

Description was changed from

==========
Add ClientNativePixmap multi-planar support.

ClientNativePixmap, that lets clients map pixmaps in user space,
always assumed a pixmap contained only one plane.

This CL adds support for multiple-planes.

BUG=618516
TBR=posciak
TEST=gl_unittests on samus.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add ClientNativePixmap multi-planar support.

ClientNativePixmap, that lets clients map pixmaps in user space,
always assumed a pixmap contained only one plane.

This CL adds support for multiple-planes.

BUG=618516
TBR=posciak
TEST=gl_unittests on samus.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/cdb357b81306f5e8170027d13d931b8e26140405
Cr-Commit-Position: refs/heads/master@{#420251}
==========

[commit-bot: I haz the power, 2016-09-22 03:29:18]

Patchset 8 (id:??) landed as
https://crrev.com/cdb357b81306f5e8170027d13d931b8e26140405
Cr-Commit-Position: refs/heads/master@{#420251}

[Daniele Castagna, 2016-09-22 23:35:28]

A revert of this CL (patchset #8 id:160001) has been created in
https://codereview.chromium.org/2361023003/ by dcastagna@chromium.org.

The reason for reverting is: This makes samus stuck at the Chrome logo..

[Daniele Castagna, 2016-09-27 18:59:40]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 19:00:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 19:14:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 19:14:53]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Daniele Castagna, 2016-09-27 19:18:21]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[Daniele Castagna, 2016-09-27 19:18:32]

The previous patch broke CrOS since NativePixmapPlane::size was not passed to
the renderer during IPCs.

+sadrul for ui/gfx/mojo/*
+rsesek for ui/gfx/ipc/gfx_param_traits_macros.h

[commit-bot: I haz the power, 2016-09-27 19:18:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniele Castagna, 2016-09-27 19:19:29]

dcastagna@chromium.org changed reviewers:
+ rsesek@chromium.org, sadrul@chromium.org

[Daniele Castagna, 2016-09-27 19:19:30]

This time actually adding sadrul and rsesek.

The previous patch broke CrOS since NativePixmapPlane::size was not passed to
the renderer during IPCs.

+sadrul for ui/gfx/mojo/*
+rsesek for ui/gfx/ipc/gfx_param_traits_macros.h

[Robert Sesek, 2016-09-27 20:39:47]

LGTM

[commit-bot: I haz the power, 2016-09-27 23:14:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 23:14:38]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-09-28 16:20:45]

lgtm

[Daniele Castagna, 2016-09-28 16:30:48]

The CQ bit was checked by dcastagna@chromium.org

[Daniele Castagna, 2016-09-28 16:30:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
ccameron@chromium.org, reveman@chromium.org, spang@chromium.org
Link to the patchset: https://codereview.chromium.org/2272153002/#ps200001
(title: "ifdef USE_OZONE for unused variables.")

[commit-bot: I haz the power, 2016-09-28 16:31:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 16:43:45]

Committed patchset #10 (id:200001)

[commit-bot: I haz the power, 2016-09-28 16:49:37]

Description was changed from

==========
Add ClientNativePixmap multi-planar support.

ClientNativePixmap, that lets clients map pixmaps in user space,
always assumed a pixmap contained only one plane.

This CL adds support for multiple-planes.

BUG=618516
TBR=posciak
TEST=gl_unittests on samus.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/cdb357b81306f5e8170027d13d931b8e26140405
Cr-Commit-Position: refs/heads/master@{#420251}
==========

to

==========
Add ClientNativePixmap multi-planar support.

ClientNativePixmap, that lets clients map pixmaps in user space,
always assumed a pixmap contained only one plane.

This CL adds support for multiple-planes.

BUG=618516
TBR=posciak
TEST=gl_unittests on samus.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/cdb357b81306f5e8170027d13d931b8e26140405
Committed: https://crrev.com/3085817730f8c6eacc1b6f02e78a712aefcaaacd
Cr-Original-Commit-Position: refs/heads/master@{#420251}
Cr-Commit-Position: refs/heads/master@{#421543}
==========

[commit-bot: I haz the power, 2016-09-28 16:49:38]

Patchset 10 (id:??) landed as
https://crrev.com/3085817730f8c6eacc1b6f02e78a712aefcaaacd
Cr-Commit-Position: refs/heads/master@{#421543}