Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 226223005: Revert of Removing the mock-keychain related bool from GCMStore constructor (Closed)

Created:
6 years, 8 months ago by fgorski
Modified:
6 years, 8 months ago
Reviewers:
Nicolas Zea, jianli
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Removing the mock-keychain related bool from GCMStore constructor (https://codereview.chromium.org/221453003/) Reason for revert: gcm_unit_tests were disabled on a Mac because they were hanging on build bots. This is due to a combination of factors such as gcm_unit_tests not running in the CQ and possible keychain related configuration updates. In order to fix the problem step by step, this change will have to be attempted again. Original issue's description: > Removing the mock-keychain related bool from GCMStore constructor > > Removing the first parameter of GCMStore constructor. > Adding BuildGCMStore to GCMInternalsBuilder. > > BUG=342360 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261842 TBR=jianli@chromium.org,zea@chromium.org NOTREECHECKS=true NOTRY=true BUG=342360 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262333

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -35 lines) Patch
M google_apis/gcm/engine/gcm_store_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M google_apis/gcm/engine/gcm_store_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M google_apis/gcm/engine/gcm_store_impl_unittest.cc View 2 chunks +1 line, -4 lines 0 comments Download
M google_apis/gcm/engine/mcs_client_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M google_apis/gcm/gcm_client_impl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M google_apis/gcm/gcm_client_impl.cc View 2 chunks +1 line, -9 lines 0 comments Download
M google_apis/gcm/gcm_client_impl_unittest.cc View 3 chunks +0 lines, -15 lines 0 comments Download
M google_apis/gcm/tools/mcs_probe.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
fgorski
Created Revert of Removing the mock-keychain related bool from GCMStore constructor
6 years, 8 months ago (2014-04-08 04:48:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fgorski@chromium.org/226223005/1
6 years, 8 months ago (2014-04-08 04:48:18 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-08 05:32:16 UTC) #3
Message was sent while issue was closed.
Change committed as 262333

Powered by Google App Engine
This is Rietveld 408576698