DescriptionRevert of Removing the mock-keychain related bool from GCMStore constructor (https://codereview.chromium.org/221453003/)
Reason for revert:
gcm_unit_tests were disabled on a Mac because they were hanging on build bots. This is due to a combination of factors such as gcm_unit_tests not running in the CQ and possible keychain related configuration updates. In order to fix the problem step by step, this change will have to be attempted again.
Original issue's description:
> Removing the mock-keychain related bool from GCMStore constructor
>
> Removing the first parameter of GCMStore constructor.
> Adding BuildGCMStore to GCMInternalsBuilder.
>
> BUG=342360
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261842
TBR=jianli@chromium.org,zea@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=342360
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262333
Patch Set 1 #
Created: 6 years, 8 months ago
(Patch set is too large to download)
Messages
Total messages: 3 (0 generated)
|